Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6 Imagify plugin path not correct #7

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Fix #6 Imagify plugin path not correct #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
df30824
Release for v1.0.1 (#5)
jeawhanlee Oct 21, 2024
0c8a7d4
:fixes: #6 change imagify plugin path
Khadreal Oct 25, 2024
22da91b
Fix install event for imagify
Khadreal Oct 25, 2024
2796bef
Fix imagify urls
Khadreal Oct 25, 2024
60a034d
Fix lint error
Khadreal Oct 25, 2024
f982832
fix test error
Khadreal Oct 25, 2024
bd4947f
fix conflict
Khadreal Oct 25, 2024
8f58f0d
Updated README.md
jeawhanlee Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class View {
}

public function display_page() {
$plugin_family = $this->plugin_family->get_filtered_plugins( 'imagify-plugin/imagify' );
$plugin_family = $this->plugin_family->get_filtered_plugins( 'imagify/imagify' );

$data = [
'plugin_family' => $plugin_family['uncategorized'],
Expand Down
2 changes: 1 addition & 1 deletion src/Controller/PluginFamily.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public static function get_post_install_event(): array {
$allowed_plugin = [
'uk-cookie-consent',
'backwpup',
'imagify-plugin',
'imagify',
'seo-by-rank-math',
'wp-rocket',
];
Expand Down
4 changes: 2 additions & 2 deletions src/Model/PluginFamily.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class PluginFamily {
* @var array
*/
protected $wp_rocket_referrer = [
'imagify-plugin' => 'imagify',
'imagify' => 'imagify',
'seo-by-rank-math' => '',
'backwpup' => '',
'uk-cookie-consent' => '',
Expand Down Expand Up @@ -92,7 +92,7 @@ public function filter_plugins_by_activation( array $plugins, string $main_plugi
'plugin_to_install' => rawurlencode( $plugin ),
];

if ( 'imagify-plugin' === $plugin_slug ) {
if ( 'imagify' === $plugin_slug ) {
$args = [
'action' => 'install_imagify_from_partner_' . $main_plugin_slug,
'_wpnonce' => wp_create_nonce( 'install_imagify_from_partner' ),
Expand Down
4 changes: 2 additions & 2 deletions src/Model/wp_media_plugins.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
'optimize_performance' => [
'title' => 'Optimize Performance',
'plugins' => [
'wp-rocket/wp-rocket' => [
'wp-rocket/wp-rocket' => [
'logo' => [
'file' => 'logo-wp-rocket.svg',
'width' => '50%',
Expand All @@ -16,7 +16,7 @@
'desc' => 'WP Rocket is the easiest way to make your WordPress website faster and boost your Google PageSpeed score. Get more traffic, better engagement, and higher conversions effortlessly.',
'link' => '',
],
'imagify-plugin/imagify' => [
'imagify/imagify' => [
'logo' => [
'file' => 'logo-imagify.svg',
'width' => '50%',
Expand Down
12 changes: 6 additions & 6 deletions tests/Fixtures/src/Model/PluginFamily/filterPluginsByActivation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
'desc' => 'WP Rocket is the easiest way to make your WordPress website faster and boost your Google PageSpeed score. Get more traffic, better engagement, and higher conversions effortlessly.',
'link' => 'https://wp-rocket.me/?utm_source=imagify-coupon&utm_medium=plugin&utm_campaign=imagify',
],
'imagify-plugin/imagify' => [
'imagify/imagify' => [
'logo' => [
'file' => 'logo-imagify.svg',
'width' => '50%',
Expand Down Expand Up @@ -116,7 +116,7 @@
'optimize_performance' => [
'title' => 'Optimize Performance',
'plugins' => [
'imagify-plugin/imagify' => [
'imagify/imagify' => [
'logo' => [
'file' => 'logo-imagify.svg',
'width' => '50%',
Expand Down Expand Up @@ -202,7 +202,7 @@
'url' => 'http://example.org/wp-admin/admin-post.php?action=plugin_family_install_wp-rocket&_wpnonce=9a68f00b8d&plugin_to_install=wp-rocket%2Fwp-rocket'
],
],
'imagify-plugin/imagify' => [
'imagify/imagify' => [
'logo' => [
'file' => 'logo-imagify.svg',
'width' => '50%',
Expand Down Expand Up @@ -257,7 +257,7 @@
'url' => 'https://wp-rocket.me/?utm_source=-coupon&utm_medium=plugin&utm_campaign='
],
],
'imagify-plugin/imagify' => [
'imagify/imagify' => [
'logo' => [
'file' => 'logo-imagify.svg',
'width' => '50%',
Expand Down Expand Up @@ -312,14 +312,14 @@
'plugins' => $plugins,
'main_plugin' => 'wp-rocket/wp-rocket',
'order' => 'categorized',
'active_plugin' => 'imagify-plugin/imagify.php',
'active_plugin' => 'imagify/imagify.php',
],
'expected' => $expectedActivePluginAsTheLastElement,
],
'testShouldReturnCategoryWithActivePluginAsTheLastElement' => [
'config' => [
'plugins' => $plugins,
'main_plugin' => 'imagify-plugin/imagify',
'main_plugin' => 'imagify/imagify',
'order' => 'uncategorized',
'active_plugin' => 'seo-by-rank-math/rank-math.php',
],
Expand Down
Loading