Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6 Imagify plugin path not correct #7

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Fix #6 Imagify plugin path not correct #7

merged 8 commits into from
Oct 25, 2024

Conversation

Khadreal
Copy link
Contributor

Description

Fixes #6
Fix imagify plugin path

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Check #6

Technical description

Documentation

Explain how this code works. Diagrams & drawings are welcome.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

jeawhanlee and others added 2 commits October 21, 2024 14:18
@jeawhanlee
Release for v1.0.1 (#5)
df30824 
* Initial commit

* Added phpcs

* Added lint config

* Updated config file

* Added gitignore

* Fixed phpcs errors

* Ignore composer.lock

* Added tests

* Added patchwork config

* Updated composer packages and script

* Updated method

* Updated namespace

* Updated namespace and methods

* Added test workflow

* Remove test cache

* Ignore test cache

* Updated README

* Updated README

* Updated README

* Updated README

* Updated test

* Updated README

* Updated namespace

* Added phpstan

* Fixed phpstan errors

* Updated composer.json

* Added phpstan config

* Added workflow file for phpstan

* Updated namespace

* use defined var

* Updated README

* Updated tests

* Make wp rocket referrer dynamic

* Updated data

* Updated tests

* Added git attribute file

* Fixed phpcs
@Khadreal
:fixes: #6 change imagify plugin path
0c8a7d4
@Khadreal Khadreal changed the title :fixes: #6 change imagify plugin path Fix #6 Imagify plugin path not correct Oct 25, 2024
@Khadreal Khadreal requested a review from jeawhanlee October 25, 2024 06:06
jeawhanlee
jeawhanlee reviewed Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@jeawhanlee jeawhanlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have another change to make here too

@jeawhanlee
Copy link
Collaborator

Linter is failing as well.

@jeawhanlee jeawhanlee changed the base branch from trunk to develop October 25, 2024 06:49
@Khadreal Khadreal requested a review from jeawhanlee October 25, 2024 08:57
@jeawhanlee jeawhanlee merged commit e664dde into develop Oct 25, 2024
7 checks passed
@jeawhanlee jeawhanlee mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeawhanlee jeawhanlee jeawhanlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Imagify plugin path not correct
2 participants
@Khadreal @jeawhanlee