Make Stats-related entities Equatable #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
staskus
force-pushed
the
task/stats-insights-diffable-optimization
branch
from
98f4a4d to
13122be
Compare
staskus
force-pushed
the
task/stats-insights-diffable-optimization
branch
from
13122be to
76359e4
Compare
staskus
force-pushed
the
task/stats-insights-diffable-optimization
branch
from
76359e4 to
518a4a5
Compare
guarani
approved these changes
Apr 5, 2024
|
Thanks, @guarani ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: wordpress-mobile/WordPress-iOS#22720
Description
Some of these Stats Insights-related entities are not Equatable, making it difficult to use them within a modern SwiftUI/UIKit context. Making it Equatable outside the library doesn't automatically generate conformance.
Testing Details
The library should be built by CI.
CHANGELOG.mdif necessary.