-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats Insights: Optimize table view updates by integrating diffable data source #22592
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
4ec49cd
to
ce0d1fe
Compare
Generated by 🚫 dangerJS |
02c194f
to
d9c51c2
Compare
@guarani review for this can wait after we're done with Traffic tab. |
I added Stats Insights Details support in this PR. These two PRs should cover diffable data source support for all the Stats. |
Related to the failing CI checks: https://a8c.slack.com/archives/C05N140C8H5/p1710357494940709 |
I moved this to a new GitHub project, more context here: p1710464002701159-slack-C06BR07TJHK |
TODO: Requires the same fix #22857 Done: |
…y methods Usage of performBatchUpdates is not allowed if table view depends on a diffable data source and can result in crashes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and can see the improvement!
The changes themselves were hard to review due to the number of lines updated, so I skimmed the changes and relied on testing.
Use a diffable data source within Stats Insights and Stats Insights Details to make table view cell reloads more efficient. More information about implementation in: #22542
Related diff: wordpress-mobile/WordPressKit-iOS#751
To test:
Regression Notes
Breaking loading of data within existing Stats Insights and Stats Insights Details.
SiteStatsInsightsViewModelTests
should still succeedPR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: