runfix: 1:1 conversation with user without key packages #17371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrykBuniX
force-pushed
the
runfix/1to1-migration-no-keys
branch
from
db972cf to
8d27e8a
Compare
PatrykBuniX
commented
May 16, 2024
Comment on lines
-1506
to
-1512
| private readonly updateConversationReadOnlyState = async ( | ||
| conversationEntity: Conversation, | ||
| conversationReadOnlyState: CONVERSATION_READONLY_STATE | null, | ||
| ) => { | ||
| conversationEntity.readOnlyState(conversationReadOnlyState); | ||
| await this.saveConversationStateInDb(conversationEntity); | ||
| }; |
There was a problem hiding this comment.
We don't need to save the state manually, there's a subscription that updates the db whenever the value changes. See https://github.com/wireapp/wire-webapp/blob/runfix/1to1-migration-no-keys/src/script/entity/Conversation.ts#L582
|
przemvs
approved these changes
May 16, 2024
PatrykBuniX
added a commit
that referenced
this pull request
May 16, 2024
* refactor: update conversaiton readonly state * runfix: optionally do not allow unestablished mls 1:1 * feat: add a placeholder message for readonly 1:1 with a user without keys * runfix: update copy * test: readonly mls 1:1 no available keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handles a 1:1 conversation with a user that don't have any key packages available to establish a MLS 1:1 conversation.
Screenshots/Screencast (for UI changes)
Checklist