Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Streamline leaving and clearing conversation #15965

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Oct 10, 2023

Description

Avoid mixing clearing and leaving conversation. Make the code much leaner and avoid confusion between those 2 actions

previously: leaveConversation and clearConversation could both do leaving AND clearing the conversation.
now: leaveConversation only does leaving and clearConversation only does clearing

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #15965 (5581021) into dev (c2bd51f) will increase coverage by 0.00%.
Report is 1 commits behind head on dev.
The diff coverage is 4.34%.

@@           Coverage Diff           @@
##              dev   #15965   +/-   ##
=======================================
  Coverage   44.28%   44.29%           
=======================================
  Files         683      683           
  Lines       22918    22916    -2     
  Branches     5213     5211    -2     
=======================================
  Hits        10150    10150           
+ Misses      11467    11465    -2     
  Partials     1301     1301           

@atomrc atomrc force-pushed the fix/stop-federating branch from 23922e1 to 3ae923a Compare October 10, 2023 14:41
@atomrc atomrc force-pushed the fix/stop-federating branch from 3ae923a to 5581021 Compare October 10, 2023 14:42
Copy link
Contributor

@PatrykBuniX PatrykBuniX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I agree it was hard to follow the flow with the previous structure 👌

@atomrc atomrc merged commit 58c0f59 into dev Oct 10, 2023
13 checks passed
@atomrc atomrc deleted the fix/stop-federating branch October 10, 2023 14:53
@PatrykBuniX PatrykBuniX mentioned this pull request Oct 11, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants