runfix: leave mls conversation #15972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrykBuniX
commented
Oct 11, 2023
| return this.removeMembersLocally(conversation, [userQualifiedId]); | ||
| } | ||
|
|
||
| const events = await this.removeMembersFromConversation(conversation, [userQualifiedId]); |
There was a problem hiding this comment.
We cannot call .removeMembers method. We want to always delete the user "the proteus way", no need to check for conversation protocol.
Codecov Report
@@ Coverage Diff @@
## dev #15972 +/- ##
==========================================
+ Coverage 44.29% 44.36% +0.06%
==========================================
Files 684 684
Lines 22905 22908 +3
Branches 5204 5204
==========================================
+ Hits 10146 10163 +17
+ Misses 11457 11442 -15
- Partials 1302 1303 +1 |
atomrc
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#15965 introduced a regression in leaving MLS conversations. Leaving a MLS conversation is different than removing other users (we cannot send remove proposal for the self client, remove proposal has to be created by backend). When leaving MLS conversation we should remove self user "the proteus way", so just send a request to backend. For more details see https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/157287189/Use+case+leaving+a+conversation.
Checklist