Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allowing empty team name when migrating [WPB-15092] #3763

Merged

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Dec 20, 2024

TaskWPB-15092 [Android]User is able to create a team name consisting only of spaces.


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When a personal user migrates to a team account, the "Your Team" input field allows the user to enter only spaces as the team name and proceed with registration. This results in invalid or meaningless team names, which should not be permitted.

Solutions

Modify the check for enabling "continue" button to also check whether the name is not blank.
Trim all excessive spaces at the start of end of the name.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Steps to Reproduce:
-Log in to the Android app as a personal user on the Anta BE environment.
-Start the process to migrate to a team account.
-In the Team Name Overlay, enter only spaces (e.g., " ") in the "Your Team" input field.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.73%. Comparing base (df5ef14) to head (4b7ebce).

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3763   +/-   ##
==================================================
  Coverage              45.73%   45.73%           
==================================================
  Files                    473      473           
  Lines                  16094    16094           
  Branches                2717     2717           
==================================================
  Hits                    7361     7361           
  Misses                  7972     7972           
  Partials                 761      761           
Files with missing lines Coverage Δ
...serprofile/teammigration/TeamMigrationViewModel.kt 75.92% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5ef14...4b7ebce. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3763.apk is available for download

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great as always

@saleniuk saleniuk added this pull request to the merge queue Dec 20, 2024
Merged via the queue into release/candidate with commit 4427e89 Dec 20, 2024
14 of 15 checks passed
@saleniuk saleniuk deleted the fix/alowing-empty-team-name-when-migrating branch December 20, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants