-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allowing empty team name when migrating [WPB-15092] #3763
fix: allowing empty team name when migrating [WPB-15092] #3763
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3763 +/- ##
==================================================
Coverage 45.73% 45.73%
==================================================
Files 473 473
Lines 16094 16094
Branches 2717 2717
==================================================
Hits 7361 7361
Misses 7972 7972
Partials 761 761
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3763.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great as always
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When a personal user migrates to a team account, the "Your Team" input field allows the user to enter only spaces as the team name and proceed with registration. This results in invalid or meaningless team names, which should not be permitted.
Solutions
Modify the check for enabling "continue" button to also check whether the name is not blank.
Trim all excessive spaces at the start of end of the name.
Testing
Test Coverage (Optional)
How to Test
Steps to Reproduce:
-Log in to the Android app as a personal user on the Anta BE environment.
-Start the process to migrate to a team account.
-In the Team Name Overlay, enter only spaces (e.g., " ") in the "Your Team" input field.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.