fix: allowing empty team name when migrating [WPB-15092] 🍒 #3764
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
cherry-pick
|
saleniuk
requested review from
a team,
typfel,
alexandreferris,
borichellow,
saleniuk and
mathias-niboulies
and removed request for
a team
|
Built wire-android-staging-compat-pr-3764.apk is available for download |
|
Built wire-android-dev-debug-pr-3764.apk is available for download |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When a personal user migrates to a team account, the "Your Team" input field allows the user to enter only spaces as the team name and proceed with registration. This results in invalid or meaningless team names, which should not be permitted.
Solutions
Modify the check for enabling "continue" button to also check whether the name is not blank.
Trim all excessive spaces at the start of end of the name.
Testing
Test Coverage (Optional)
How to Test
Steps to Reproduce:
-Log in to the Android app as a personal user on the Anta BE environment.
-Start the process to migrate to a team account.
-In the Team Name Overlay, enter only spaces (e.g., " ") in the "Your Team" input field.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.