Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: countly sdk integration replace halt and bump to latest (WPB-15007) #3748

Merged
merged 1 commit into from
Dec 16, 2024
+2 −2
Merged

fix: countly sdk integration replace halt and bump to latest (WPB-15007) #3748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...bled/src/main/kotlin/com/wire/android/feature/analytics/AnonymousAnalyticsRecorderImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class AnonymousAnalyticsRecorderImpl : AnonymousAnalyticsRecorder {

override fun halt() = wrapCountlyRequest {
isConfigured = false
Countly.sharedInstance().halt()
Countly.sharedInstance()?.consent()?.removeConsentAll()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guy got overridden by other changes, eventually this gets rid of the crash, since halt is not meant for production code.

}

override suspend fun setTrackingIdentifierWithMerge(
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ coil = "2.7.0"
commonmark = "0.24.0"

# Countly
countly = "24.4.0"
countly = "24.7.7"

# RSS
rss-parser = "6.0.7"
Expand Down
Loading