fix: countly sdk integration replace halt and bump to latest (WPB-15007) #3748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes/initiative: product-metrics-in-countly
|
yamilmedina
changed the title
yamilmedina
commented
Dec 16, 2024
| @@ -86,7 +86,7 @@ class AnonymousAnalyticsRecorderImpl : AnonymousAnalyticsRecorder { | |||
|
|
|||
| override fun halt() = wrapCountlyRequest { | |||
| isConfigured = false | |||
| Countly.sharedInstance().halt() | |||
| Countly.sharedInstance()?.consent()?.removeConsentAll() | |||
There was a problem hiding this comment.
This guy got overridden by other changes, eventually this gets rid of the crash, since halt is not meant for production code.
vitorhugods
approved these changes
Dec 16, 2024
saleniuk
approved these changes
Dec 16, 2024
auto-merge was automatically disabled
December 16, 2024 16:19
Pull Request is not mergeable
auto-merge was automatically disabled
December 16, 2024 16:20
Pull Request is not mergeable
|
Built wire-android-staging-compat-pr-3748.apk is available for download |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
After a couple of PRs addressing countly, the fixes from last week got overridden.
Causes (Optional)
Crash on call to halt.
Solutions
Bring back the fix, and bump countly to latest.
Testing
Test Coverage (Optional)
How to Test
Have 2 accounts with countly; one enabled, second disabled.
First go to enabled account, then go to disabled and send app to BG
Expected:
When bringing app from "recent apps" there should no be crash, since we are not calling halt anymore, but rather:
Countly.sharedInstance()?.consent()?.removeConsentAll()Attachments
Screen.Recording.2024-12-16.at.17.01.59.mov
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.