-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: conference simulcast support (WPB-11480) #3744
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3744 +/- ##
===========================================
+ Coverage 45.71% 45.76% +0.05%
===========================================
Files 477 477
Lines 16189 16199 +10
Branches 2743 2744 +1
===========================================
+ Hits 7400 7413 +13
+ Misses 8020 8017 -3
Partials 769 769
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3744.apk is available for download |
Built wire-android-dev-debug-pr-3744.apk is available for download |
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3744.apk is available for download |
Built wire-android-dev-debug-pr-3744.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Note
Bring back the simulcast revert
Issues
On AVS 10.x.x, we have finally supported for Simulcast (multiple quality for participants video). This is an improvement in the overall experience, and as well in performance, because when the client is with a Tile in FullScreen, we can request only that video stream, saving bandwidth.
Solutions
Add the code to support, this consist in simple words:
wcall_request_video_streams
we send a new parameter call (quality)Also took the chance to improve some things in the code:
Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
As of now, it is not possible, but when SFT version 5 is deployed on staging, it will be possible.
For development purposes, was 'hacked' using the SFT test server and local webapp.
Attachments (Optional)
https://drive.google.com/file/d/18N0W4hXT3MDfL_tsD0_rJCzgDz5s4D9D/view?usp=sharing
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.