Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: conference simulcast support (WPB-11480) #3744

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Dec 16, 2024

StoryWPB-11480 [Android] Simulcast Support & Automatic Quality Adjustments


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Note

Bring back the simulcast revert

Issues

On AVS 10.x.x, we have finally supported for Simulcast (multiple quality for participants video). This is an improvement in the overall experience, and as well in performance, because when the client is with a Tile in FullScreen, we can request only that video stream, saving bandwidth.

Solutions

Add the code to support, this consist in simple words:

  • When requesting the video streams wcall_request_video_streams we send a new parameter call (quality)
  • ANY = 0, LOW = 1, HIGH = 2.

Also took the chance to improve some things in the code:

  • Calling Logging
  • JSON serializer was being created every time we requested streams, now is using a shared instance.

Dependencies (Optional)

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

As of now, it is not possible, but when SFT version 5 is deployed on staging, it will be possible.
For development purposes, was 'hacked' using the SFT test server and local webapp.

Attachments (Optional)

https://drive.google.com/file/d/18N0W4hXT3MDfL_tsD0_rJCzgDz5s4D9D/view?usp=sharing


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Dec 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.76%. Comparing base (21ee4fc) to head (e82516e).

Files with missing lines Patch % Lines
...android/ui/calling/ongoing/OngoingCallViewModel.kt 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3744      +/-   ##
===========================================
+ Coverage    45.71%   45.76%   +0.05%     
===========================================
  Files          477      477              
  Lines        16189    16199      +10     
  Branches      2743     2744       +1     
===========================================
+ Hits          7400     7413      +13     
+ Misses        8020     8017       -3     
  Partials       769      769              
Files with missing lines Coverage Δ
...id/ui/calling/ongoing/fullscreen/FullScreenTile.kt 0.00% <ø> (ø)
.../calling/ongoing/fullscreen/SelectedParticipant.kt 100.00% <100.00%> (+100.00%) ⬆️
...android/ui/calling/ongoing/OngoingCallViewModel.kt 76.31% <90.90%> (+3.18%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ee4fc...e82516e. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3744.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3744.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Dec 17, 2024
@yamilmedina yamilmedina removed this pull request from the merge queue due to a manual request Dec 17, 2024
@MohamadJaara MohamadJaara added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 17, 2024
@yamilmedina yamilmedina added this pull request to the merge queue Dec 17, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3744.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3744.apk is available for download

Merged via the queue into develop with commit e0e5c8b Dec 17, 2024
13 of 14 checks passed
@yamilmedina yamilmedina deleted the feat/simulcast-rerevert branch December 17, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants