-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: conference simulcast support (WPB-11480) #3150
Conversation
Bencher Report
Click to view all benchmark results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3150 +/- ##
===========================================
- Coverage 54.14% 54.13% -0.01%
===========================================
Files 1252 1253 +1
Lines 36528 36546 +18
Branches 3703 3705 +2
===========================================
+ Hits 19777 19784 +7
- Misses 15326 15338 +12
+ Partials 1425 1424 -1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3239 Passed, 107 Skipped, 1m 2.26s Total Time |
Bringing back simulcast to 4.11 |
Quality Gate passedIssues Measures |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
On AVS 10.x.x, we have finally supported for Simulcast (multiple quality for participants video). This is an improvement in the overall experience, and as well in performance, because when the client is with a Tile in FullScreen, we can request only that video stream, saving bandwidth.
Solutions
Add the code to support, this consist in simple words:
wcall_request_video_streams
we send a new parameter call (quality)Also took the chance to improve some things in the code:
Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
As of now, it is not possible, but when SFT version 5 is deployed on staging, it will be possible.
For development purposes, was 'hacked' using the SFT test server and local webapp.
Attachments (Optional)
https://drive.google.com/file/d/18N0W4hXT3MDfL_tsD0_rJCzgDz5s4D9D/view?usp=sharing
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.