-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cherry pick improvements #2298
Conversation
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1125 succeeded. The build produced the following APK's: |
APKs built during tests are available here. Scroll down to Artifacts! |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1155 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Really great. Awesome work
I wonder if we could make it an action of its own tho. Future improvement, maybe.
In a way that it would be easy to just create a wokflow file and add the action with parameters and voilà.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
release/candidate
branch.Causes (Optional)
Solutions
Descriptive Comments:
Environment Variables:
SUBMODULE_NAME
to allow dynamic handling based on the submodule's presence.TARGET_BRANCH
variable, enabling users to specify a different branch for cherry-picking rather than the defaultdevelop
.Dynamic Submodule Handling:
SUBMODULE_NAME
. If set, the script focuses on changes outside that submodule; otherwise, it considers all changes.Submodule Update:
Squashing Commits:
Cherry-pick Strategy Adjustment:
--strategy-option theirs
. This favors the changes from the PR being cherry-picked during conflicts.Improved Conflict Handling:
Temporary Branch Cleanup:
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.