Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cherry-pick improvements #2341

Closed

Conversation

AndroidBob
Copy link
Collaborator

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
kalium


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Cherry-picked from develop to RC #2298

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Oct 18, 2023
@github-actions
Copy link
Contributor

@AndroidBob looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
d5bd000e14c50b23fa1622c5ff27184403987aa3 8f461bcda1e13ade2a92f87ca0c9fb9b19a57feb

Is this intentional?

@github-actions
Copy link
Contributor

Test Results

649 tests  ±0   649 ✔️ ±0   8m 37s ⏱️ + 3m 9s
  94 suites ±0       0 💤 ±0 
  94 files   ±0       0 ±0 

Results for commit 9d3c816. ± Comparison against base commit 4bcd746.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 1390 succeeded.

The build produced the following APK's:

@Garzas
Copy link
Contributor

Garzas commented Oct 18, 2023

There is already code there

@Garzas Garzas closed this Oct 18, 2023
@yamilmedina yamilmedina deleted the feat/cherry-pick-improvements-cherry-pick branch April 12, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants