Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync other users after personal to team migration - RC (WPB-14871) #3206

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Jan 2, 2025

TaskWPB-14871 [Android] Guest label for personal users only shown after migration once conversation is opened


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

After migration from personal to team account, guest label is not displayed for users that are not in the team that is recently created.

Causes (Optional)

User type s not updated after migration, it stays as NONE.

Solutions

Sync other users to get the correct users type

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarqubecloud bot commented Jan 2, 2025

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Test Results

3 349 tests  ±0   3 241 ✅ ±0   6m 14s ⏱️ +26s
  572 suites ±0     108 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit 48aad03. ± Comparison against base commit 7f1da82.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: Guest-label-for-personal-users-not-shown-after-migration
Commit report: b0262f7
Test service: kalium-jvm

✅ 0 Failed, 3241 Passed, 108 Skipped, 1m 4.94s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.16%. Comparing base (7f1da82) to head (48aad03).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3206      +/-   ##
=====================================================
- Coverage              54.16%   54.16%   -0.01%     
=====================================================
  Files                   1250     1250              
  Lines                  36504    36506       +2     
  Branches                3699     3699              
=====================================================
+ Hits                   19772    19773       +1     
- Misses                 15302    15303       +1     
  Partials                1430     1430              
Files with missing lines Coverage Δ
.../com/wire/kalium/logic/data/user/UserRepository.kt 67.44% <100.00%> (ø)
...user/migration/MigrateFromPersonalToTeamUseCase.kt 81.81% <100.00%> (+1.17%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1da82...48aad03. Read the comment docs.

@ohassine ohassine changed the title feat: Sync other users after personal to team migration (WPB-14871) feat: Sync other users after personal to team migration - RC (WPB-14871) Jan 3, 2025
@ohassine ohassine added this pull request to the merge queue Jan 3, 2025
Merged via the queue into release/candidate with commit 13c44e1 Jan 3, 2025
25 checks passed
@ohassine ohassine deleted the Guest-label-for-personal-users-not-shown-after-migration branch January 3, 2025 09:08
github-actions bot pushed a commit that referenced this pull request Jan 3, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 6, 2025
…(WPB-14871) 🍒 (#3207)

* feat: show Guest label for personal users after migration in conversations screen (#3206)

* chore: Empty-Commit

---------

Co-authored-by: Oussama Hassine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants