Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync other users after personal to team migration - cherrypick (WPB-14871) 🍒 #3207

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 3, 2025

TaskWPB-14871 [Android] Guest label for personal users only shown after migration once conversation is opened

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

After migration from personal to team account, guest label is not displayed for users that are not in the team that is recently created.

Causes (Optional)

User type s not updated after migration, it stays as NONE.

Solutions

Sync other users to get the correct users type

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarqubecloud bot commented Jan 3, 2025

@ohassine ohassine requested review from a team, m-zagorski, MohamadJaara, vitorhugods, Garzas and saleniuk and removed request for a team January 3, 2025 16:36
Copy link
Contributor Author

github-actions bot commented Jan 3, 2025

Test Results

3 378 tests  ±0   3 271 ✅ ±0   5m 12s ⏱️ -8s
  580 suites ±0     107 💤 ±0 
  580 files   ±0       0 ❌ ±0 

Results for commit e777c4e. ± Comparison against base commit 6ddef73.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

github-actions bot commented Jan 3, 2025

@ohassine ohassine enabled auto-merge January 3, 2025 16:53
@datadog-wireapp
Copy link

Datadog Report

Branch report: Guest-label-for-personal-users-not-shown-after-migration-cherry-pick
Commit report: 3d1a564
Test service: kalium-jvm

✅ 0 Failed, 3271 Passed, 107 Skipped, 1m 0.21s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.10%. Comparing base (6ddef73) to head (e777c4e).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3207      +/-   ##
===========================================
- Coverage    54.11%   54.10%   -0.02%     
===========================================
  Files         1264     1264              
  Lines        36800    36802       +2     
  Branches      3735     3735              
===========================================
- Hits         19915    19912       -3     
- Misses       15446    15450       +4     
- Partials      1439     1440       +1     
Files with missing lines Coverage Δ
.../com/wire/kalium/logic/data/user/UserRepository.kt 68.04% <100.00%> (ø)
...user/migration/MigrateFromPersonalToTeamUseCase.kt 81.81% <100.00%> (+1.17%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ddef73...e777c4e. Read the comment docs.

@ohassine ohassine changed the title feat: Sync other users after personal to team migration - RC (WPB-14871) 🍒 feat: Sync other users after personal to team migration - cherrypick (WPB-14871) 🍒 Jan 3, 2025
@ohassine ohassine added this pull request to the merge queue Jan 6, 2025
Merged via the queue into develop with commit 1adf523 Jan 6, 2025
26 checks passed
@ohassine ohassine deleted the Guest-label-for-personal-users-not-shown-after-migration-cherry-pick branch January 6, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants