Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream IDL changes from Trusted Types #10199

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

lukewarlow
Copy link
Member

@lukewarlow lukewarlow commented Mar 13, 2024

(See WHATWG Working Mode: Changes for more details.)


/dom.html ( diff )
/dynamic-markup-insertion.html ( diff )
/iframe-embed-object.html ( diff )
/infrastructure.html ( diff )
/references.html ( diff )
/workers.html ( diff )

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside an IDL block we use <span> to reference code constructs, not <code>. Looks mostly good otherwise.

source Show resolved Hide resolved
source Show resolved Hide resolved
@lukewarlow lukewarlow marked this pull request as ready for review March 14, 2024 12:38
@lukewarlow lukewarlow requested a review from annevk March 14, 2024 12:39
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dontcallmedom do you foresee this causing any issues for the various IDL tools?

source Show resolved Hide resolved
source Outdated Show resolved Hide resolved
@dontcallmedom
Copy link
Contributor

@dontcallmedom do you foresee this causing any issues for the various IDL tools?

none that I can see

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it to @domenic and @zcorpan whether they're okay with doing this incrementally.

source Show resolved Hide resolved
@zcorpan
Copy link
Member

zcorpan commented Mar 18, 2024

I think incremental upstreaming is OK.

Are the open threads above resolved?

@lukewarlow
Copy link
Member Author

Are the open threads above resolved?

Yeah apologies forgot to close them.

@lukewarlow
Copy link
Member Author

is there a preference for what the commit message should say? And is there anything else that I need to do?

@zcorpan
Copy link
Member

zcorpan commented Mar 19, 2024

Upstream IDL changes from Trusted Types

Part of https://github.com/w3c/trusted-types/issues/476

and maybe repost #10199 (comment) there, since it's the tracking issue for upstreaming.

@lukewarlow
Copy link
Member Author

Have changed the commit message and reposted that comment

@zcorpan zcorpan merged commit cf95931 into whatwg:main Mar 19, 2024
2 checks passed
lukewarlow added a commit to lukewarlow/trusted-types that referenced this pull request Mar 19, 2024
lukewarlow added a commit to lukewarlow/trusted-types that referenced this pull request Mar 19, 2024
lukewarlow added a commit to w3c/trusted-types that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants