Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch trusted types sinks to use union type #10286

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

lukewarlow
Copy link
Member

@lukewarlow lukewarlow commented Apr 18, 2024

Switch Trusted Types sinks to use union IDL type

After recent discussions we've decided to change trusted types to use union IDL types across all sinks. This requires changes to the IDL and algorithms for the various sinks.

(See WHATWG Working Mode: Changes for more details.)


/dom.html ( diff )
/dynamic-markup-insertion.html ( diff )
/iframe-embed-object.html ( diff )
/infrastructure.html ( diff )
/workers.html ( diff )

@lukewarlow

This comment was marked as outdated.

source Outdated Show resolved Hide resolved
@lukewarlow lukewarlow marked this pull request as ready for review April 29, 2024 17:21
@lukewarlow lukewarlow requested a review from annevk April 29, 2024 17:21
source Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Outdated Show resolved Hide resolved
@lukewarlow lukewarlow requested a review from annevk May 2, 2024 12:09
source Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
@lukewarlow lukewarlow requested a review from zcorpan May 15, 2024 14:16
source Show resolved Hide resolved
@zcorpan
Copy link
Member

zcorpan commented May 28, 2024

The diff view shows document.write and writeln with HTMLString. I suppose this needs to be rebased so that #10199 is included, and update those to union type here.

@lukewarlow
Copy link
Member Author

I've rebased atop the document.write PR and removed the strings from this PR

source Show resolved Hide resolved
This replaces usages of HTMLString and ScriptURLString with their equivalent union types.

The relevant algorithms are also updated to do the TT enforcement.
@lukewarlow
Copy link
Member Author

@zcorpan @annevk is this ready to be merged now it's rebased?

@zcorpan zcorpan merged commit 8e5944d into whatwg:main Jun 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants