fix: always add semicolon in concaten module and tweak #18713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
alexander-akait
approved these changes
Aug 27, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Revert the source change in #18709, the test cases are reserved. Resolve web-infra-dev/rspack#7591.
After adding new tests cases in this PR, I found it's hard to determine when to add the leading semicolon, as comments may appear before real code. Considering the risks and benefits of implementation, I decide to revert #18709 until we found a cheap and safe implementation. I also added new test cases by the way.
There's still a little change I made to resolve web-infra-dev/rspack#7591: remove
CONCATENATED MODULE:prefix to make it easier for users to understand.Did you add tests for your changes?
Yes.
Does this PR introduce a breaking change?
No.
What needs to be documented once your changes are merged?
No.