Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ASI in the concatenated module only when necessary #7688

Closed
wants to merge 1 commit into from

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Aug 26, 2024

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Aug 26, 2024
@fi3ework
Copy link
Member Author

!bench

Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 876f80b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66cc96d3eb0f3200087fd9fb

@rspack-bot
Copy link

rspack-bot commented Aug 26, 2024

📝 Benchmark detail: Open

Name Base (2024-08-26 36df3c2) Current Change
10000_development-mode + exec 2.37 s ± 34 ms 2.34 s ± 37 ms -1.03 %
10000_development-mode_hmr + exec 698 ms ± 7 ms 711 ms ± 10 ms +1.83 %
10000_production-mode + exec 3.07 s ± 30 ms 3.03 s ± 33 ms -1.26 %
arco-pro_development-mode + exec 1.89 s ± 58 ms 1.87 s ± 99 ms -1.04 %
arco-pro_development-mode_hmr + exec 437 ms ± 2.7 ms 438 ms ± 2.3 ms +0.05 %
arco-pro_production-mode + exec 3.51 s ± 56 ms 3.47 s ± 81 ms -1.08 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.55 s ± 120 ms 3.54 s ± 89 ms -0.20 %
threejs_development-mode_10x + exec 1.69 s ± 7.3 ms 1.7 s ± 8 ms +0.24 %
threejs_development-mode_10x_hmr + exec 804 ms ± 9.6 ms 798 ms ± 9 ms -0.76 %
threejs_production-mode_10x + exec 5.57 s ± 17 ms 5.55 s ± 34 ms -0.31 %

@fi3ework
Copy link
Member Author

Diff test failed to pass, I will port to webpack first.

@fi3ework
Copy link
Member Author

Close as per webpack/webpack#18713.

@fi3ework fi3ework closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants