Move hide event before state changes on :open
#37029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 18, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4032919
branch
from
daf6651 to
5e24198
Compare
Move the timing of the popover `popoverhide` event a bit earlier in the process, just *before* the state changes to "transitioning". This has the effect of making the state clean (either :open or :closed) for both `popoverhide` and `popovershow`. See the discussion here: openui/open-ui#607 Bug: 1307772 Change-Id: I5aaabfd48204e54831ce435c71a54e692e139caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4032919 Reviewed-by: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1074159}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4032919
branch
from
5e24198 to
948353d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the timing of the popover
popoverhideevent a bit earlierin the process, just before the state changes to "transitioning".
This has the effect of making the state clean (either :open or
:closed) for both
popoverhideandpopovershow.See the discussion here:
openui/open-ui#607
Bug: 1307772
Change-Id: I5aaabfd48204e54831ce435c71a54e692e139caf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4032919
Reviewed-by: Joey Arhar <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1074159}