Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move hide event before state changes on
:open
Move the timing of the popover `popoverhide` event a bit earlier in the process, just *before* the state changes to "transitioning". This has the effect of making the state clean (either :open or :closed) for both `popoverhide` and `popovershow`. See the discussion here: openui/open-ui#607 Bug: 1307772 Change-Id: I5aaabfd48204e54831ce435c71a54e692e139caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4032919 Reviewed-by: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1074159}
- Loading branch information
8bb98a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh! Looks like an error! Details
HttpError: You have exceeded a secondary rate limit. Please wait a few minutes before you try again.