Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scroll to text fragment #2459

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Update scroll to text fragment #2459

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f132b4
Update scroll to text fragment
jamesnw Dec 17, 2024
8360cb0
Merge branch 'main' of github.com:web-platform-dx/web-features into f…
jamesnw Dec 18, 2024
8e6fb70
Add html key, cleanup comments
jamesnw Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions features/scroll-to-text-fragment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,19 @@ group:
caniuse: url-scroll-to-text-fragment
# This feature isn't in BCD, so the status manually matches caniuse instead:
status:
baseline: false
baseline: low
baseline_low_date: 2024-09-30
support:
chrome: "81"
chrome_android: "81"
edge: "83"
firefox: "131"
firefox_android: "131"
safari: "16.1"
safari_ios: "16.1"
# document.fragmentDirective cannot be considered part of this feature due to
# https://webkit.org/b/273466. TODO: Consider partial support for this feature
# depending on https://github.com/WICG/scroll-to-text-fragment/issues/257.
# compat_features:
# - api.Document.fragmentDirective
# - api.FragmentDirective
compat_features:
- api.Document.fragmentDirective
- api.FragmentDirective
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the right thing to do here now is:

  • Add html.elements.a.text_fragments to compat_features
  • Use compute_from: html.elements.a.text_fragments to do the override (instead of the manual one here)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh excellent! That makes things much better, thanks for tracking that down.

19 changes: 18 additions & 1 deletion features/scroll-to-text-fragment.yml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,21 @@
# Generated from: scroll-to-text-fragment.yml
# Do not edit this file by hand. Edit the source file instead!

{}
compat_features:
# baseline: false
# support:
# chrome: "81"
# chrome_android: "81"
# edge: "83"
# firefox: "131"
# firefox_android: "131"
- api.FragmentDirective

# baseline: false
# support:
# chrome: "86"
# chrome_android: "86"
# edge: "86"
# firefox: "131"
# firefox_android: "131"
- api.Document.fragmentDirective
Loading