Update scroll to text fragment #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
I think this might actually exist as |
ddbeck
requested changes
Dec 18, 2024
features/scroll-to-text-fragment.yml
Outdated
Comment on lines
10
to
25
| baseline: false | ||
| baseline: low | ||
| baseline_low_date: 2024-09-30 | ||
| support: | ||
| chrome: "81" | ||
| chrome_android: "81" | ||
| edge: "83" | ||
| firefox: "131" | ||
| firefox_android: "131" | ||
| safari: "16.1" | ||
| safari_ios: "16.1" | ||
| # document.fragmentDirective cannot be considered part of this feature due to | ||
| # https://webkit.org/b/273466. TODO: Consider partial support for this feature | ||
| # depending on https://github.com/WICG/scroll-to-text-fragment/issues/257. | ||
| # compat_features: | ||
| # - api.Document.fragmentDirective | ||
| # - api.FragmentDirective | ||
| compat_features: | ||
| - api.Document.fragmentDirective | ||
| - api.FragmentDirective |
There was a problem hiding this comment.
I think the right thing to do here now is:
- Add
html.elements.a.text_fragmentstocompat_features - Use
compute_from: html.elements.a.text_fragmentsto do the override (instead of the manual one here)
There was a problem hiding this comment.
Oh excellent! That makes things much better, thanks for tracking that down.
ddbeck
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1007 and #732 for context.
Essentially, the feature itself is not in BCD, so the status in manually set. This adds Firefox support, which makes it baseline low (and matches Caniuse).
Separately, feature detection was not added in Safari, and has been sitting behind a feature flag. It will be enabled by default in Safari at some later date, per WebKit/WebKit#36413.
This adds the keys for feature detection. We'll need to do more cleanup once Safari supports feature detection.