Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support module.size function in cacheGroups.[i].test #7482

Merged
merged 21 commits into from
Aug 9, 2024
Merged

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Aug 7, 2024

Summary

feat: support module.size function in cacheGroups.[i].test

Relate #7269

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: feature release: feature related release(mr only) labels Aug 7, 2024
Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 506e804
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66b5e059e268500008a8486d

@SyMind SyMind marked this pull request as ready for review August 7, 2024 10:16
@SyMind
Copy link
Member Author

SyMind commented Aug 7, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Aug 7, 2024

📝 Benchmark detail: Open

Name Base (2024-08-07 0b5ee31) Current Change
10000_development-mode + exec 2.32 s ± 22 ms 2.32 s ± 29 ms +0.21 %
10000_development-mode_hmr + exec 706 ms ± 7.7 ms 706 ms ± 8.5 ms +0.13 %
10000_production-mode + exec 2.85 s ± 23 ms 2.9 s ± 45 ms +1.79 %
arco-pro_development-mode + exec 1.88 s ± 60 ms 1.91 s ± 44 ms +1.30 %
arco-pro_development-mode_hmr + exec 434 ms ± 2.1 ms 434 ms ± 3.8 ms +0.03 %
arco-pro_production-mode + exec 3.62 s ± 262 ms 3.45 s ± 84 ms -4.74 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.55 s ± 192 ms 3.49 s ± 81 ms -1.74 %
threejs_development-mode_10x + exec 1.71 s ± 13 ms 1.71 s ± 16 ms +0.20 %
threejs_development-mode_10x_hmr + exec 826 ms ± 8.9 ms 831 ms ± 8.5 ms +0.64 %
threejs_production-mode_10x + exec 5.51 s ± 33 ms 5.52 s ± 31 ms +0.15 %

@JSerFeng
Copy link
Contributor

JSerFeng commented Aug 8, 2024

Docs need to be modified as well

@SyMind
Copy link
Member Author

SyMind commented Aug 9, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Aug 9, 2024

📝 Benchmark detail: Open

Name Base (2024-08-08 2bd905d) Current Change
10000_development-mode + exec 2.32 s ± 27 ms 2.32 s ± 36 ms -0.15 %
10000_development-mode_hmr + exec 701 ms ± 7.3 ms 698 ms ± 12 ms -0.42 %
10000_production-mode + exec 2.85 s ± 23 ms 2.88 s ± 41 ms +1.11 %
arco-pro_development-mode + exec 1.89 s ± 75 ms 1.9 s ± 70 ms +0.76 %
arco-pro_development-mode_hmr + exec 434 ms ± 2.4 ms 434 ms ± 1.2 ms +0.08 %
arco-pro_production-mode + exec 3.52 s ± 286 ms 3.39 s ± 73 ms -3.72 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.54 s ± 235 ms 3.51 s ± 55 ms -1.06 %
threejs_development-mode_10x + exec 1.72 s ± 15 ms 1.71 s ± 15 ms -0.16 %
threejs_development-mode_10x_hmr + exec 826 ms ± 9.5 ms 821 ms ± 6.9 ms -0.61 %
threejs_production-mode_10x + exec 5.53 s ± 29 ms 5.5 s ± 35 ms -0.57 %

@SyMind SyMind force-pushed the module.size branch 2 times, most recently from fdf210f to dd23e72 Compare August 9, 2024 08:28
@JSerFeng JSerFeng merged commit ba260c5 into main Aug 9, 2024
28 checks passed
@JSerFeng JSerFeng deleted the module.size branch August 9, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants