fix

web-infra-dev · Aug 7, 2024 · e2eff03 · e2eff03
1 parent d65c2bb
commit e2eff03
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/crates/node_binding/binding.d.ts b/crates/node_binding/binding.d.ts
@@ -103,7 +103,7 @@ export class JsCompilation {
   rebuildModule(moduleIdentifiers: Array<string>, f: (...args: any[]) => any): void
   importModule(request: string, publicPath: JsFilename | undefined | null, baseUri: string | undefined | null, originalModule: string | undefined | null, originalModuleContext: string | undefined | null, callback: (...args: any[]) => any): void
   get entries(): JsEntries
-  finalize(): void
+  dispose(): void
 }
 
 export class JsEntries {

diff --git a/crates/rspack_binding_values/src/compilation/mod.rs b/crates/rspack_binding_values/src/compilation/mod.rs
@@ -560,7 +560,7 @@ impl JsCompilation {
   }
 
   #[napi]
-  pub fn finalize(&self, env: Env) {
+  pub fn dispose(&self, env: Env) {
     // TODO: use napi_add_finalizer if N-API version >= 5
     let compilation_id = self.0.id();
 

diff --git a/packages/rspack/etc/api.md b/packages/rspack/etc/api.md
@@ -1017,7 +1017,7 @@ export class Compilation {
     // @internal
     __internal__setAssetSource(filename: string, source: Source): void;
     // @internal
-    __internal_finalize(): void;
+    __internal_dispose(): void;
     // @internal
     __internal_getInner(): binding.JsCompilation;
     get assets(): Record<string, Source>;

diff --git a/packages/rspack/src/Compilation.ts b/packages/rspack/src/Compilation.ts
@@ -1138,8 +1138,8 @@ BREAKING CHANGE: Asset processing hooks in Compilation has been merged into a si
 	 *
 	 * @internal
 	 */
-	__internal_finalize() {
-		return this.#inner.finalize();
+	__internal_dispose() {
+		return this.#inner.dispose();
 	}
 
 	seal() {}

diff --git a/packages/rspack/src/Compiler.ts b/packages/rspack/src/Compiler.ts
@@ -621,7 +621,7 @@ class Compiler {
 				this.#compilation!.startTime = startTime;
 				this.#compilation!.endTime = Date.now();
 				this.hooks.afterCompile.callAsync(this.#compilation!, err => {
-					this.#compilation!.__internal_finalize();
+					this.#compilation!.__internal_dispose();
 					if (err) {
 						return callback(err);
 					}