Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing dependencies should be recoverable #5152

Merged
merged 8 commits into from
Jan 9, 2024
Merged

fix: missing dependencies should be recoverable #5152

merged 8 commits into from
Jan 9, 2024

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Dec 28, 2023 •
edited
Loading

Summary

Support recover from missing dependencies being added back.

Test Plan

See e2e test changes.

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@h-a-n-a h-a-n-a mentioned this pull request Dec 28, 2023
Merged
2 tasks
@h-a-n-a Graphite App
Copy link
Contributor Author

h-a-n-a commented Dec 28, 2023 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @h-a-n-a and the rest of your teammates on Graphite Graphite

@h-a-n-a h-a-n-a mentioned this pull request Dec 28, 2023
Merged
2 tasks
@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Dec 28, 2023
@h-a-n-a h-a-n-a mentioned this pull request Dec 28, 2023
Merged
2 tasks
@h-a-n-a h-a-n-a self-assigned this Dec 28, 2023
Base automatically changed from 12-27-fix_missing_dependencies_should_be_recoverable to main December 28, 2023 12:19
@h-a-n-a h-a-n-a mentioned this pull request Jan 2, 2024
Merged
2 tasks
@h-a-n-a h-a-n-a force-pushed the 12-27-fix_missing_dependencies_should_be_recoverable_split branch 3 times, most recently from a96282c to e8468ca Compare January 5, 2024 09:57
@h-a-n-a h-a-n-a changed the base branch from main to 01-05-chore_bump_oxc January 5, 2024 09:57
@h-a-n-a h-a-n-a mentioned this pull request Jan 5, 2024
Merged
2 tasks
@h-a-n-a h-a-n-a force-pushed the 01-05-chore_bump_oxc branch 3 times, most recently from 5c44521 to 9d8f907 Compare January 5, 2024 10:14
@h-a-n-a h-a-n-a force-pushed the 12-27-fix_missing_dependencies_should_be_recoverable_split branch from e8468ca to 378c367 Compare January 5, 2024 10:14
@h-a-n-a h-a-n-a force-pushed the 01-05-chore_bump_oxc branch 4 times, most recently from 437f3f0 to 6653d66 Compare January 8, 2024 10:06
@h-a-n-a h-a-n-a force-pushed the 12-27-fix_missing_dependencies_should_be_recoverable_split branch from 378c367 to 55a928e Compare January 8, 2024 10:16
@h-a-n-a h-a-n-a marked this pull request as ready for review January 8, 2024 10:23
@h-a-n-a h-a-n-a requested a review from a team January 8, 2024 10:23
@h-a-n-a h-a-n-a requested a review from hardfist as a code owner January 8, 2024 10:23
@h-a-n-a h-a-n-a force-pushed the 01-05-chore_bump_oxc branch from 6653d66 to 1818088 Compare January 8, 2024 11:12
@h-a-n-a h-a-n-a requested a review from a team January 8, 2024 11:12
@h-a-n-a h-a-n-a requested review from LingyuCoder and ahabhgk January 8, 2024 11:12
@h-a-n-a h-a-n-a force-pushed the 12-27-fix_missing_dependencies_should_be_recoverable_split branch 2 times, most recently from 13f6efd to 76cfe2c Compare January 8, 2024 11:14
Base automatically changed from 01-05-chore_bump_oxc to main January 8, 2024 11:31
@h-a-n-a h-a-n-a force-pushed the 12-27-fix_missing_dependencies_should_be_recoverable_split branch 2 times, most recently from 021668c to a35e355 Compare January 8, 2024 11:38
@h-a-n-a h-a-n-a force-pushed the 12-27-fix_missing_dependencies_should_be_recoverable_split branch from a35e355 to 366a347 Compare January 9, 2024 06:34
@h-a-n-a h-a-n-a enabled auto-merge (squash) January 9, 2024 08:00
@h-a-n-a h-a-n-a disabled auto-merge January 9, 2024 08:00
@h-a-n-a h-a-n-a enabled auto-merge (squash) January 9, 2024 08:00
@h-a-n-a h-a-n-a force-pushed the 12-27-fix_missing_dependencies_should_be_recoverable_split branch from b6bc51b to c7c598e Compare January 9, 2024 08:04
@h-a-n-a h-a-n-a merged commit 0a5a2dd into main Jan 9, 2024
17 checks passed
@h-a-n-a h-a-n-a deleted the 12-27-fix_missing_dependencies_should_be_recoverable_split branch January 9, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

@hardfist hardfist Awaiting requested review from hardfist

@IWANABETHATGUY IWANABETHATGUY Awaiting requested review from IWANABETHATGUY

@ScriptedAlchemy ScriptedAlchemy Awaiting requested review from ScriptedAlchemy

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder

@ahabhgk ahabhgk Awaiting requested review from ahabhgk

Assignees

@h-a-n-a h-a-n-a

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-a-n-a @Boshen