clean up

web-infra-dev · Jan 9, 2024 · c7c598e · c7c598e
1 parent 78f7d30
commit c7c598e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 16 deletions.
diff --git a/packages/playground/cases/file/missing-files/index.test.ts b/packages/playground/cases/file/missing-files/index.test.ts
@@ -22,12 +22,8 @@ test("missing files should be able to recover if being added back", async ({
 		() => "export const b = 'missing-file-2'"
 	);
 
-	await expect(page.locator("#missing-file-1")).toHaveText("missing-file-1", {
-		timeout: 30 * 1000
-	});
-	await expect(page.locator("#missing-file-2")).toHaveText("missing-file-2", {
-		timeout: 30 * 1000
-	});
+	await expect(page.locator("#missing-file-1")).toHaveText("missing-file-1");
+	await expect(page.locator("#missing-file-2")).toHaveText("missing-file-2");
 
 	fileAction.deleteFile("src/missing-file-1.js");
 
@@ -40,7 +36,5 @@ test("missing files should be able to recover if being added back", async ({
 		() => "export const a = 'missing-file-1'"
 	);
 
-	await expect(page.locator("#missing-file-1")).toHaveText("missing-file-1", {
-		timeout: 30 * 1000
-	});
+	await expect(page.locator("#missing-file-1")).toHaveText("missing-file-1");
 });
diff --git a/packages/rspack/src/Watching.ts b/packages/rspack/src/Watching.ts
@@ -329,10 +329,6 @@ export class Watching {
 			if (err) return handleError(err, cbs);
 			// @ts-expect-error
 			this.handler(null, stats);
-			console.log(
-				[...compilation.fileDependencies],
-				[...compilation.missingDependencies]
-			);
 
 			process.nextTick(() => {
 				if (!this.#closed) {

diff --git a/packages/rspack/tests/MultiCompiler.test.ts b/packages/rspack/tests/MultiCompiler.test.ts
@@ -488,10 +488,15 @@ describe("MultiCompiler", function () {
 
 		compiler.watch({}, err => {
 			if (err) {
-				done(err);
-			} else {
-				done();
+				compiler.close(() => {
+					done(err);
+				});
+				return;
 			}
+			compiler.close(err => {
+				if (err) return done(err);
+				done();
+			});
 		});
 	}, 20000);