Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support option resolveLoader #4008

Merged
merged 5 commits into from
Aug 25, 2023
Merged

feat: support option resolveLoader #4008

merged 5 commits into from
Aug 25, 2023

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Aug 22, 2023 •
edited
Loading

Summary

closes #3737

Added support for resolveLoader. However, nodejs-resolver does not support
alias with a custom query or fragment, which results in the failure with the first webpack test case.

Test Plan

See test changes and add back the first test once resolve.alias supports custom query and fragment.

@github-actions github-actions bot added release: feature team The issue/pr is created by the member of Rspack. labels Aug 22, 2023
@h-a-n-a h-a-n-a mentioned this pull request Aug 22, 2023
Closed
@h-a-n-a h-a-n-a marked this pull request as ready for review August 22, 2023 09:11
@h-a-n-a h-a-n-a requested a review from a team August 22, 2023 09:11
@h-a-n-a h-a-n-a requested a review from ahabhgk as a code owner August 22, 2023 09:11
@h-a-n-a h-a-n-a requested review from a team, LingyuCoder, ScriptedAlchemy and hyf0 August 22, 2023 09:11
hyf0
hyf0 previously approved these changes Aug 22, 2023
View reviewed changes
@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented Aug 22, 2023 •
edited
Loading

Too bad, CI failed it.skip is not a function: https://github.com/web-infra-dev/rspack/actions/runs/5936765987/job/16098346469?pr=4008#step:8:673

@h-a-n-a h-a-n-a force-pushed the feat/option-resolve-loader branch 2 times, most recently from f1ca839 to dd09c21 Compare August 22, 2023 11:17
@h-a-n-a h-a-n-a changed the base branch from main to 0.3.0 August 23, 2023 03:09
@h-a-n-a h-a-n-a changed the base branch from 0.3.0 to main August 23, 2023 03:09
@h-a-n-a h-a-n-a force-pushed the feat/option-resolve-loader branch from dd09c21 to 404144c Compare August 25, 2023 08:16
@h-a-n-a h-a-n-a enabled auto-merge August 25, 2023 08:16
@github-actions
Copy link
Contributor

Test Compatibility Diff

main pr diff
52.127% 52.323% ✅ ⏫ 0.196

@h-a-n-a h-a-n-a added this pull request to the merge queue Aug 25, 2023
Merged via the queue into main with commit c5f1697 Aug 25, 2023
@h-a-n-a h-a-n-a deleted the feat/option-resolve-loader branch August 25, 2023 10:17
@h-a-n-a h-a-n-a added the need documentation Create a tracking issue in rspack-website label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyf0 hyf0 hyf0 approved these changes

@ahabhgk ahabhgk Awaiting requested review from ahabhgk

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder

@ScriptedAlchemy ScriptedAlchemy Awaiting requested review from ScriptedAlchemy

Assignees
No one assigned
Labels
need documentation Create a tracking issue in rspack-website team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support resolveLoader
2 participants
@h-a-n-a @hyf0