Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support aliased resolving #4009

Closed
h-a-n-a opened this issue Aug 22, 2023 · 13 comments · Fixed by #7660
Closed

Support aliased resolving #4009

h-a-n-a opened this issue Aug 22, 2023 · 13 comments · Fixed by #7660
Assignees
Labels
bug Something isn't working
Milestone

Comments

@h-a-n-a
Copy link
Contributor

h-a-n-a commented Aug 22, 2023

          Currently, Due to the fact that nodejs-resolver does not support resolving with alias, Rspack does not support resolve aliased loader. We should fix this.

Originally posted by @h-a-n-a in #4008 (comment)

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Aug 22, 2023
@h-a-n-a h-a-n-a added bug Something isn't working and removed team The issue/pr is created by the member of Rspack. labels Aug 22, 2023
@hardfist
Copy link
Contributor

hardfist commented Sep 8, 2023

@Boshen can verify whether is resolved?

Copy link

stale bot commented Nov 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Nov 7, 2023
@Boshen
Copy link
Contributor

Boshen commented Nov 8, 2023

Where are the tests for "resolve aliased loader"? Let's try and turn them on so we can close this issue.

@stale stale bot removed the stale label Nov 8, 2023
@hardfist
Copy link
Contributor

hardfist commented Nov 8, 2023

Where are the tests for "resolve aliased loader"? Let's try and turn them on so we can close this issue.

@Boshen try turn on this for oxc resolver https://github.com/web-infra-dev/rspack/pull/4008/files#diff-cd6dcd934ac301a223707a61b3bba520be1c3ee63a00ba24e6cbe8bb79ccf266R6, I think this is used to test agains alias with query case(which is not supported in the old nodejs_resolver), cc @h-a-n-a

@Boshen
Copy link
Contributor

Boshen commented Dec 8, 2023

@h-a-n-a This PR from webpack indicates that this should be solved on the Rspack side?

https://github.com/webpack/webpack/pull/3445/files#diff-d73b6d4cb18e533b6d82864565571fb5d0b87455a67503db7464eff699bfea1a

@Boshen Boshen assigned h-a-n-a and unassigned Boshen Jan 8, 2024
@Narretz
Copy link

Narretz commented Jan 24, 2024

So this is about the alias option in the config, right?

It does compile with aliases, but re-compilation on file changes doesn't work if the file path is imported via alias. Is this the correct issue for this problem, and are there any news on this?

@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented Feb 2, 2024

So this is about the alias option in the config, right?

It does compile with aliases, but re-compilation on file changes doesn't work if the file path is imported via alias. Is this the correct issue for this problem, and are there any news on this?

@Narretz I assume this is a different issue than this one, would you please create another issue?

Copy link

stale bot commented Apr 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Apr 2, 2024
@Narretz
Copy link

Narretz commented Apr 7, 2024

I believe it's still not clear if everything related to Alias Resolving is tested correctly.

@stale stale bot removed the stale label Apr 7, 2024
Copy link

stale bot commented Jun 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Jun 6, 2024
@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented Jun 11, 2024

bump

@stale stale bot removed the stale label Jun 11, 2024
Copy link

stale bot commented Aug 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Aug 10, 2024
@hardfist hardfist added this to the 1.0.0 milestone Aug 13, 2024
@hardfist
Copy link
Contributor

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants