ci: don't cancel jobs on main (#5563)

web-infra-dev · Feb 1, 2024 · 8072775 · 8072775 · rspack-bot · Feb 1, 2024
1 parent 40241c9
commit 8072775
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml
@@ -4,10 +4,9 @@ on:
   issue_comment:
     types: [created]
 
-# cancel previous job runs for the same workflow + pr
 concurrency:
-  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
-  cancel-in-progress: true
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
+  cancel-in-progress: ${{ github.ref_name != 'main' }}
 
 jobs:
   trigger:

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -23,7 +23,7 @@ on:
       - "**"
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
   cancel-in-progress: ${{ github.ref_name != 'main' }}
 
 jobs:
Name	Base (2024-02-01 e4dc2f4)	Current	Change
10000_development-mode + exec	1.7 s ± 14 ms	1.67 s ± 19 ms	-1.68 %
10000_development-mode_hmr + exec	950 ms ± 10 ms	914 ms ± 4.4 ms	-3.78 %
10000_production-mode + exec	2.75 s ± 46 ms	2.62 s ± 33 ms	-4.93 %
arco-pro_development-mode + exec	2.69 s ± 32 ms	2.69 s ± 46 ms	-0.27 %
arco-pro_development-mode_hmr + exec	1.09 s ± 16 ms	1.07 s ± 23 ms	-2.18 %
arco-pro_production-mode + exec	4.29 s ± 57 ms	4.34 s ± 65 ms	+1.21 %
threejs_development-mode_10x + exec	1.99 s ± 25 ms	1.93 s ± 25 ms	-3.16 %
threejs_development-mode_10x_hmr + exec	1.23 s ± 14 ms	1.13 s ± 7.5 ms	-8.23 %
threejs_production-mode_10x + exec	5.81 s ± 40 ms	5.73 s ± 133 ms	-1.42 %