chore: align more tests (#5558)

chore: init
web-infra-dev · Feb 1, 2024 · 40241c9 · 40241c9 · rspack-bot · Feb 1, 2024
1 parent c829ab4
commit 40241c9
Show file tree

Hide file tree

Showing 30 changed files with 604 additions and 532 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -10,3 +10,4 @@ webpack-test
 examples
 diffcases
 scripts/test/diff.cjs
+scripts/test/binary-path.cjs
diff --git a/.typos.toml b/.typos.toml
@@ -16,6 +16,7 @@ extend-exclude = [
   "GOVERNANCE.md",
   "pnpm-lock.yaml",
   "scripts/test/diff.cjs",
+  "scripts/test/binary-path.cjs",
 ]
 
 [default.extend-words]

diff --git a/.../configCases/asset-url/relative/index.css → ...ases/asset-url/relative-rewrite/index.css b/.../configCases/asset-url/relative/index.css → ...ases/asset-url/relative-rewrite/index.css
diff --git a/...s/configCases/asset-url/relative/index.js → ...Cases/asset-url/relative-rewrite/index.js b/...s/configCases/asset-url/relative/index.js → ...Cases/asset-url/relative-rewrite/index.js
@@ -1,4 +1,5 @@
 it("should compile", () => {
+	// See: https://github.com/web-infra-dev/rspack/pull/5397
 	const url = new URL("./index.css?query=yes#fragment", import.meta.url).href;
 	expect(url).toBeDefined();
 });
diff --git a/...ases/asset-url/relative/webpack.config.js → ...et-url/relative-rewrite/webpack.config.js b/...ases/asset-url/relative/webpack.config.js → ...et-url/relative-rewrite/webpack.config.js
diff --git a/packages/rspack/tests/configCases/externals/externals-system/index.js b/packages/rspack/tests/configCases/externals/externals-system/index.js
diff --git a/packages/rspack/tests/configCases/externals/externals-system/reexport-external.js b/packages/rspack/tests/configCases/externals/externals-system/reexport-external.js
diff --git a/packages/rspack/tests/configCases/externals/externals-system/test.config.js b/packages/rspack/tests/configCases/externals/externals-system/test.config.js
diff --git a/packages/rspack/tests/configCases/externals/externals-system/webpack.config.js b/packages/rspack/tests/configCases/externals/externals-system/webpack.config.js
diff --git a/packages/rspack/tests/helpers/FakeDocument.js b/packages/rspack/tests/helpers/FakeDocument.js
@@ -72,6 +72,7 @@ class FakeElement {
 		this._document._onElementAttached(node);
 		this._children.push(node);
 		node.parentNode = this;
+		// CHANGE: TODO description
 		if (node._type === "link" || node._type === "script") {
 			setTimeout(() => {
 				if (node.onload) node.onload({ type: "load", target: node });

diff --git a/packages/rspack/tests/hotCases/errors/events/index.js b/packages/rspack/tests/hotCases/errors/events/index.js
@@ -51,11 +51,10 @@ it("should fire the correct events", done => {
 	}
 
 	waitForUpdate(() => {
-		const error = msg => 
+		const error = msg =>
 			expect.objectContaining({
 				message: msg
 			});
-
 		expect(events).toEqual([
 			{
 				type: "unaccepted",

diff --git a/packages/rspack/tests/hotCases/errors/events/k.js b/packages/rspack/tests/hotCases/errors/events/k.js
@@ -4,10 +4,7 @@ export default i;
 if (module.hot) {
 	module.hot.accept(
 		"./i",
-		() => {
-			// TODO remove this
-			__webpack_require__("./i.js");
-		},
+		() => {},
 		(err, { moduleId, dependencyId }) => {
 			throw new Error(
 				`Error in accept error handler: ${moduleId} -> ${dependencyId}`

diff --git a/packages/rspack/tests/hotCases/fake-update-loader.js b/packages/rspack/tests/hotCases/fake-update-loader.js
@@ -1,4 +1,5 @@
 module.exports = function (content) {
+	// CHANGE:
 	var idx = this.getOptions().updateIndex;
 	var items = content.split(/---+\r?\n/g);
 	if (items.length > 1) {

diff --git a/packages/rspack/tests/hotCases/invalidate/during-idle/a.js b/packages/rspack/tests/hotCases/invalidate/during-idle/a.js
diff --git a/packages/rspack/tests/hotCases/invalidate/during-idle/b.js b/packages/rspack/tests/hotCases/invalidate/during-idle/b.js
diff --git a/packages/rspack/tests/hotCases/invalidate/during-idle/c.js b/packages/rspack/tests/hotCases/invalidate/during-idle/c.js
diff --git a/packages/rspack/tests/hotCases/invalidate/during-idle/index.js b/packages/rspack/tests/hotCases/invalidate/during-idle/index.js
diff --git a/packages/rspack/tests/hotCases/invalidate/during-idle/module.js b/packages/rspack/tests/hotCases/invalidate/during-idle/module.js
diff --git a/packages/rspack/tests/watchCases/simple/simple/0/changing-file.js b/packages/rspack/tests/watchCases/simple/simple/0/changing-file.js
diff --git a/packages/rspack/tests/watchCases/simple/simple/0/index.js b/packages/rspack/tests/watchCases/simple/simple/0/index.js
diff --git a/packages/rspack/tests/watchCases/simple/simple/1/changing-file.js b/packages/rspack/tests/watchCases/simple/simple/1/changing-file.js
diff --git a/packages/rspack/tests/watchCases/simple/simple/2/changing-file.js b/packages/rspack/tests/watchCases/simple/simple/2/changing-file.js
Name	Base (2024-02-01 e4dc2f4)	Current	Change
10000_development-mode + exec	1.7 s ± 14 ms	1.69 s ± 39 ms	-0.68 %
10000_development-mode_hmr + exec	950 ms ± 10 ms	913 ms ± 15 ms	-3.89 %
10000_production-mode + exec	2.75 s ± 46 ms	2.7 s ± 42 ms	-2.05 %
arco-pro_development-mode + exec	2.69 s ± 32 ms	2.68 s ± 42 ms	-0.51 %
arco-pro_development-mode_hmr + exec	1.09 s ± 16 ms	1.07 s ± 13 ms	-2.19 %
arco-pro_production-mode + exec	4.29 s ± 57 ms	4.31 s ± 30 ms	+0.54 %
threejs_development-mode_10x + exec	1.99 s ± 25 ms	1.91 s ± 27 ms	-3.88 %
threejs_development-mode_10x_hmr + exec	1.23 s ± 14 ms	1.13 s ± 15 ms	-7.65 %
threejs_production-mode_10x + exec	5.81 s ± 40 ms	5.63 s ± 32 ms	-3.17 %