chore: update the example

web-infra-dev · Dec 18, 2024 · f69454d · f69454d
1 parent 36048f8
commit f69454d
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 13 deletions.
diff --git a/examples/react-component-bundle/rslib.config.ts b/examples/react-component-bundle/rslib.config.ts
@@ -25,7 +25,7 @@ export default defineConfig({
   ],
   output: {
     target: 'web',
-    assetPrefix: 'auto', // FIXME: move this line to packages/core/src/asset/assetConfig.ts
+    assetPrefix: 'auto', // TODO: move this line to packages/core/src/asset/assetConfig.ts
   },
   plugins: [pluginReact(), pluginSass()],
 });
diff --git a/packages/core/src/asset/assetConfig.ts b/packages/core/src/asset/assetConfig.ts
@@ -9,9 +9,8 @@ export const composeAssetConfig = (
     if (bundle) {
       return {
         output: {
-          // default: no inline asset
-          dataUriLimit: 0,
-          // assetPrefix: 'auto', // will turn on this with `preserveImport`
+          dataUriLimit: 0, // default: no inline asset
+          // assetPrefix: 'auto', // TODO: will turn on this with js support together in the future
         },
       };
     }

diff --git a/tests/integration/style/sass/__fixtures__/src/foundation/index.scss b/tests/integration/style/sass/__fixtures__/src/foundation/index.scss
@@ -1,3 +1,3 @@
 body {
-  // background: url(./logo.svg);
+  background: url(./logo.svg);
 }
diff --git a/tests/integration/style/sass/__fixtures__/src/index.scss b/tests/integration/style/sass/__fixtures__/src/index.scss
@@ -3,13 +3,12 @@
 // @import '~lib1/index.css';
 @import './foundation/index.scss';
 
-// TODO: asset support
-// $url: './foundation/logo.svg';
+$url: './foundation/logo.svg';
 $border-dark: rgba($base-color, 0.88);
 
-// .url-variable {
-//   background: url($url);
-// }
+.url-variable {
+  background: url($url);
+}
 
 .alert {
   border: 1px solid $border-dark;

diff --git a/tests/integration/style/sass/bundle/rslib.config.ts b/tests/integration/style/sass/bundle/rslib.config.ts
@@ -18,8 +18,6 @@ export default defineConfig({
   ],
   output: {
     target: 'web',
-    // dataUriLimit: {
-    //   svg: 0,
-    // },
+    assetPrefix: 'auto', // TODO: move this line to packages/core/src/asset/assetConfig.ts
   },
 });