chore: update the example

web-infra-dev · Dec 18, 2024 · 36048f8 · 36048f8
1 parent 613168c
commit 36048f8
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 3 deletions.
diff --git a/examples/react-component-bundle/rslib.config.ts b/examples/react-component-bundle/rslib.config.ts
@@ -25,6 +25,7 @@ export default defineConfig({
   ],
   output: {
     target: 'web',
+    assetPrefix: 'auto', // FIXME: move this line to packages/core/src/asset/assetConfig.ts
   },
   plugins: [pluginReact(), pluginSass()],
 });
diff --git a/packages/core/src/asset/assetConfig.ts b/packages/core/src/asset/assetConfig.ts
@@ -11,7 +11,7 @@ export const composeAssetConfig = (
         output: {
           // default: no inline asset
           dataUriLimit: 0,
-          assetPrefix: 'auto', // we currently not support import asset in js because of 'auto' publicPath runtime
+          // assetPrefix: 'auto', // will turn on this with `preserveImport`
         },
       };
     }

diff --git a/packages/core/tests/__snapshots__/config.test.ts.snap b/packages/core/tests/__snapshots__/config.test.ts.snap
@@ -9,6 +9,7 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
       },
       "mode": "production",
       "output": {
+        "dataUriLimit": 0,
         "distPath": {
           "css": "./",
           "cssAsync": "./",
@@ -248,6 +249,7 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config 1
       },
       "mode": "production",
       "output": {
+        "dataUriLimit": 0,
         "distPath": {
           "css": "./",
           "cssAsync": "./",

diff --git a/tests/e2e/react-component/index.pw.test.ts b/tests/e2e/react-component/index.pw.test.ts
@@ -1,8 +1,8 @@
+import assert from 'node:assert';
 import fs from 'node:fs';
 import path from 'node:path';
 import { type Page, expect, test } from '@playwright/test';
 import { dev } from 'test-helper/rsbuild';
-import assert from 'node:assert';
 
 function getCwdByExample(exampleName: string) {
   return path.join(__dirname, '../../../examples', exampleName);

diff --git a/tests/e2e/react-component/rsbuild.config.ts b/tests/e2e/react-component/rsbuild.config.ts
@@ -62,7 +62,7 @@ export default defineConfig({
   },
   output: {
     target: 'web',
-    dataUriLimit: 0
+    dataUriLimit: 0, // always emit asset for test
   },
   plugins: [
     pluginReact({