Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed changes for linking and tabindexing #21

Merged
merged 4 commits into from
Feb 27, 2020
Merged

Proposed changes for linking and tabindexing #21

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a7cb1f
add MathMLLinkableElement.idl
bkardell Feb 11, 2020
e1021b1
edits for linking
bkardell Feb 11, 2020
df6b6ae
Merge branch 'master' of https://github.com/bkardell/mathml-core
bkardell Feb 11, 2020
10d5375
Merge branch 'master' into master
bkardell Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions webidl/MathMLLinkableElement.idl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
[Exposed=Window]
interface MathMLLinkableElement : MathMLElement {
[CEReactions] attribute DOMString target;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this should closely follow:
https://html.spec.whatwg.org/#the-link-element.
So then href may be better?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on https://html.spec.whatwg.org/#the-a-element, not link

[CEReactions] attribute DOMString download;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this come from?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you are following https://html.spec.whatwg.org/#the-a-element.

[CEReactions] attribute USVString ping;
[CEReactions] attribute DOMString rel;
[SameObject, PutForwards=value] readonly attribute DOMTokenList relList;
[CEReactions] attribute DOMString hreflang;
[CEReactions] attribute DOMString type;

[CEReactions] attribute DOMString text;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this? Alt text?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from a in HTML..

a . text
Same as textContent.


[CEReactions] attribute DOMString referrerPolicy;
};

MathMLElement includes HTMLHyperlinkElementUtils;