Proposed changes for linking and tabindexing #21
Conversation
| [CEReactions] attribute DOMString hreflang; | ||
| [CEReactions] attribute DOMString type; | ||
|
|
||
| [CEReactions] attribute DOMString text; |
There was a problem hiding this comment.
from a in HTML..
a . text
Same as textContent.
| @@ -0,0 +1,16 @@ | |||
| [Exposed=Window] | |||
| interface MathMLLinkableElement : MathMLElement { | |||
| [CEReactions] attribute DOMString target; | |||
There was a problem hiding this comment.
It seems like this should closely follow:
https://html.spec.whatwg.org/#the-link-element.
So then href may be better?
There was a problem hiding this comment.
based on https://html.spec.whatwg.org/#the-a-element, not link
| [Exposed=Window] | ||
| interface MathMLLinkableElement : MathMLElement { | ||
| [CEReactions] attribute DOMString target; | ||
| [CEReactions] attribute DOMString download; |
There was a problem hiding this comment.
Where does this come from?
There was a problem hiding this comment.
Ah, you are following https://html.spec.whatwg.org/#the-a-element.
There was a problem hiding this comment.
The idl looks ok to me because it mirrors https://html.spec.whatwg.org/#htmlanchorelement.
The text property seems superflous because textContent would be similar? But I guess if it is good enough for it is good enough for MathML.
Only thing you may want to add is a constructor.
Since there is no concrete element here, I think we don't want to add that. It is, effectively, an abstract base class, basically? |
Feel free to reject this, just trying to highlight what I think we need and where for discussion re https://github.com/mathml-refresh/mathml/issues/125 and to unblock answers for https://github.com/mathml-refresh/mathml/issues/152...