Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename vc-api-test-suite-implementations to vc-test-suite-implementations and update README.md. #41

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Rename vc-api-test-suite-implementations to vc-test-suite-implementations and update README.md. #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05cee8b
Rename `vc-api-test-suite-implementations` to
JSAssassin Dec 12, 2023
e825df0
Update implementations package to use main branch and add changelog
JSAssassin Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# w3c-ccg/vc-api-verifier-test-suite ChangeLog

## 1.1.0 - 2023-12-14

### Changed
- Updated `vc-api-test-suite-implementations` package name to
`vc-test-suite-implementations`.

## 1.0.0 - 2023-11-09

### Added
Expand Down
13 changes: 9 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# vc-api-verifier-test-suite

Test Suite for Verifiers that implement the VC HTTP API

## Table of Contents
Expand Down Expand Up @@ -30,8 +31,12 @@ Note: The default issuer is set to `Digital Bazaar`, you can change the
issuer by setting the `ISSUER_NAME` env variable.

## Implementation
To add your implementation to this test suite see the [README here.](https://github.com/w3c-ccg/vc-api-test-suite-implementations)
Add the tag `vc-api` to the issuers and verifiers you want tested.
To run the tests, some implementations require client secrets that can be

To add your implementation to this test suite see the
`w3c-ccg/vc-test-suite-implementations` [README](https://github.com/w3c-ccg/vc-test-suite-implementations/blob/main/README.md). Add the tag `vc-api` to the verifiers you want
to run the tests against.

Note: To run the tests, some implementations require client secrets that can be
passed as env variables to the test script. To see which ones require client
secrets, you can check the `vc-api-test-suite-implementations` library.
secrets, you can check configs in the `w3c-ccg/vc-test-suite-implementations`
repo.
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"klona": "^2.0.5",
"mocha": "^10.0.0",
"uuid": "^9.0.1",
"vc-api-test-suite-implementations": "github:w3c-ccg/vc-api-test-suite-implementations"
"vc-test-suite-implementations": "github:w3c-ccg/vc-test-suite-implementations"
},
"devDependencies": {
"eslint": "^8.54.0",
Expand Down
4 changes: 2 additions & 2 deletions tests/10-vc-di.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
testBadRequestError
} from './helpers.js';
import chai from 'chai';
import {filterByTag} from 'vc-api-test-suite-implementations';
import {filterByTag} from 'vc-test-suite-implementations';
import {issuerName} from './test-config.js';
import {klona} from 'klona';

Expand Down Expand Up @@ -43,7 +43,7 @@ describe('Verify Credential - Data Integrity', function() {
let validVc;
before(async function() {
const issuer = matchingIssuers.get(issuerName).issuers.find(
issuer => issuer.tags.has('Ed25519Signature2020'));
issuer => issuer.tags.has('vc-api'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this just incorrect earlier? Seems different in intent/topic from the rest of the PR, no?

I've no objections to the change--and no need to extract this or anything--just curious.

Copy link
Contributor Author

@JSAssassin JSAssassin Dec 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BigBlueHat This had to be updated because Ed25519Signature2020 tags no longer exists in w3c-ccg/vc-test-suite-implementations repo. The default behavior remains unchanged though. DB's vc-api issuer is used to generate the test VC sent to verifiers for verification and the VCs still contain the Ed25519Signature2020 proof type.

validVc = await createInitialVc({issuer});
});
it('MUST verify a valid VC.', async function() {
Expand Down
2 changes: 1 addition & 1 deletion tests/11-vc-jwt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
testBadRequestError
} from './helpers.js';
import chai from 'chai';
import {filterByTag} from 'vc-api-test-suite-implementations';
import {filterByTag} from 'vc-test-suite-implementations';
import {issuerNameJWT} from './test-config.js';
import {klona} from 'klona';

Expand Down