Rename vc-api-test-suite-implementations to vc-test-suite-implementations and update README.md.
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`vc-test-suite-implementations` and update `README.md`.
BigBlueHat
approved these changes
Dec 14, 2023
| @@ -43,7 +43,7 @@ describe('Verify Credential - Data Integrity', function() { | |||
| let validVc; | |||
| before(async function() { | |||
| const issuer = matchingIssuers.get(issuerName).issuers.find( | |||
| issuer => issuer.tags.has('Ed25519Signature2020')); | |||
| issuer => issuer.tags.has('vc-api')); | |||
There was a problem hiding this comment.
Was this just incorrect earlier? Seems different in intent/topic from the rest of the PR, no?
I've no objections to the change--and no need to extract this or anything--just curious.
There was a problem hiding this comment.
@BigBlueHat This had to be updated because Ed25519Signature2020 tags no longer exists in w3c-ccg/vc-test-suite-implementations repo. The default behavior remains unchanged though. DB's vc-api issuer is used to generate the test VC sent to verifiers for verification and the VCs still contain the Ed25519Signature2020 proof type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to w3c-ccg/vc-test-suite-implementations#92, must be merged only once the PR updating the package name gets merged.PR has been merged