Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: publish to open-vsx #1255

Merged
merged 12 commits into from
Oct 31, 2022
Merged

chore: publish to open-vsx #1255

merged 12 commits into from
Oct 31, 2022

Conversation

lukashass
Copy link
Contributor

@lukashass lukashass commented May 3, 2022

This adds publishing to open-vsx in a GitHub action.

Things you would still need to do:

  1. Register at https://open-vsx.org/
  2. Set OVSX_PAT GitHub action secret
  3. Claim the Vue namespace

Additional notes

I published https://open-vsx.org/extension/lukashass/volar for testing.

Publishing with target-platform support is blocked by:

@johnsoncodehk
Copy link
Member

johnsoncodehk commented Oct 19, 2022

Hi @lukashass, thanks for your PR, I decided not add ovsx publish to local publish process, but I can accept setup a GitHub action in this repo to run ovsx publish when new tag is pushed, would you want to update this PR to GitHub action?

@lukashass
Copy link
Contributor Author

Sure, will do.

@lukashass lukashass marked this pull request as draft October 25, 2022 20:39
@lukashass lukashass marked this pull request as ready for review October 25, 2022 21:10
@lukashass
Copy link
Contributor Author

@johnsoncodehk The GitHub action should now be ready. All you need to do is described in the description 😉

A test run can be found at https://github.com/lukashass/volar/actions/runs/3324306875/jobs/5495742234

@mlbiche
Copy link

mlbiche commented Oct 28, 2022

Just restarted VSCodium, I am seeing now an installed extension from Vue with the same name as @johnsoncodehk one's. The first one is version 1.0.9 and has been published 3 days ago, while the second one is blocked to version 0.30.1.

https://open-vsx.org/extension/Vue/volar

Is it related to this merge request ?

EDIT: The new extension seems to have a better TS support with Nuxt Bridge 👍

@lukashass
Copy link
Contributor Author

@mlbiche The extension was renamed some time ago. See #1124

This PR will only replace the publishing process of Vue.volar which is currently in https://github.com/open-vsx/publish-extensions.

@johnsoncodehk Maybe we should check if Open VSX can move/redirect johnsoncodehk.volar to Vue.volar

@johnsoncodehk
Copy link
Member

@lukashass publish to lukashass.volar is good to me, can we config your OVSX_PAT? (Our team has no plan to claim the namespace for now :p)

@johnsoncodehk johnsoncodehk merged commit 37a00cd into vuejs:master Oct 31, 2022
@lukashass
Copy link
Contributor Author

@johnsoncodehk Yes, we can do that. Tough I would prefer if you create your own token (in the long run).

I could also claim the namespace myself - citing this discussion - to be able to create a bot account and/or transfer ownership to you later.

Where should I send you the access token?

@johnsoncodehk
Copy link
Member

johnsoncodehk commented Oct 31, 2022

@lukashass You can find me on discord (My id is johnsoncodehk#0495), or email [email protected]. Thanks.

@lukashass lukashass deleted the ovsx-publish branch October 31, 2022 10:59
lukashass added a commit to lukashass/publish-extensions that referenced this pull request Dec 3, 2022
Is now published from original repo, see vuejs/language-tools#1255
@johnsoncodehk
Copy link
Member

Hey @lukashass 👋, the last release CI just failed and prompted the folloing message. Is this something you can handle? Thanks in advance.
image

Doc link: https://github.com/eclipse/openvsx/wiki/Publishing-Extensions#2-log-in-and-sign-the-publisher-agreement

@lukashass
Copy link
Contributor Author

@johnsoncodehk I'm not sure what the problem is, cause my profile says:

You signed the Eclipse Foundation Open VSX Publisher Agreement 2 years ago.

I created an issue over here: eclipse/openvsx#868

There are also some similar reports about expired agreements, so I presume it is a bug with the registry and we just try to run the job again now or in a few days.

@johnsoncodehk
Copy link
Member

Release CI now successful, thanks for following up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants