Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update old version of publishing API to support platform-specific releases #1084

Closed
radeksimko opened this issue Jun 23, 2022 · 15 comments
Closed
Labels
bug Something isn't working enhancement New feature or request

Comments

@radeksimko
Copy link

The latest published version of ovsx (v0.5.0) supports platform-specific releases via ovsx --target flag.

However, the Registry running at open-vsx.org does not seem to support this.

The issue was discussed initially here:

At this point we are still blocked from publishing our extension to open-vsx.org unfortunately. The situation is worse in that I managed to publish a platform-specific extension which appears to be universal, hence appears broken for all users except for users of that single platform.

Could we get the API updated, please? 🙏🏻

@kineticsquid kineticsquid added the bug Something isn't working label Jun 23, 2022
@kineticsquid
Copy link
Contributor

@radeksimko Do you want us to un-publish your extension until we get this sorted out?

@spoenemann @mbarbero I should know this but don't, what version are we running at open-vsx.org?

@radeksimko
Copy link
Author

@kineticsquid If you could unpublish all versions above 2.20.0 (i.e. make 2.20.0 the latest available version) that would be amazing! 🙏🏻 2.20.0 is the last version which was universal, before we started publishing platform-specific ones.

https://open-vsx.org/extension/hashicorp/terraform

I should know this but don't, what version are we running at open-vsx.org?

Perhaps not related to this particular issue, but would it be useful to expose the version somewhere in footer, so that everyone can know?

@kineticsquid
Copy link
Contributor

@radeksimko Done!

@spoenemann Thoughts on this enhancement request?

@kineticsquid kineticsquid added the enhancement New feature or request label Jun 23, 2022
@spoenemann
Copy link
Contributor

I'm not deep enough into that topic. @amvanbaren @jeanp413 @filiptronicek WDYT?

@amvanbaren
Copy link
Contributor

amvanbaren commented Jun 29, 2022

eclipse/openvsx#21

It would be useful to check the server version in ovsx before executing a command, because the repository URL can vary by setting the -r parameter. It would also be useful for checking compatibility with an upstream registry.

@radeksimko
Copy link
Author

@amvanbaren am I right the production version was now updated as part of #1094 , so publishing platform-specific extensions is now possible, or are there some other changes tracked anywhere that need to happen?

@amvanbaren
Copy link
Contributor

amvanbaren commented Jul 21, 2022

@radeksimko Yes, publishing platform-specific extensions is now possible.

@radeksimko
Copy link
Author

I'm assuming this was rolled back as part of the Friday outage? https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1483

@filiptronicek
Copy link
Member

@radeksimko yes indeed, this is not possible right now again :(

@lnicola
Copy link

lnicola commented Jul 26, 2022

Yes, publishing platform-specific extensions is now possible.

We (in rust-analyzer) have a CI action that tries to publish the extension each night, and it never worked. So maybe there are multiple issues at play.

@radeksimko
Copy link
Author

@amvanbaren
Copy link
Contributor

@radeksimko open-vsx.org now does support target specific extensions, but timeouts have been reported when publishing.
Improvements are on the way. I'm blocked by helpdesk issue #2104. I've added your comment and bumped the priority to high.

@lnicola
Copy link

lnicola commented Oct 19, 2022

but timeouts have been reported when publishing

Note that on our side it reverted to returning 500.

@pm4rcin
Copy link

pm4rcin commented Dec 13, 2022

@amvanbaren how's it going because the issue you mentioned on Eclipse's gitlab was closed?

@amvanbaren
Copy link
Contributor

Hi @pm4rcin, the API supports platform-specific releases for a while now. I think the issue can be closed. @radeksimko Please re-open this issue if platform specific releases still don't work for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants