Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add input in popover to define postal code #11

Merged
merged 7 commits into from
Dec 17, 2024
Merged

feat: add input in popover to define postal code #11

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1ba9470
feat: add input in popover to define postal code
ArthurFerrao Dec 16, 2024
999330f
feat: add popover-input as default overlay
ArthurFerrao Dec 16, 2024
1138b60
feat: update messages ids
ArthurFerrao Dec 16, 2024
2236a66
fix: messages ids to postalCodeInput error
ArthurFerrao Dec 16, 2024
bf8cf34
update the CHANGELOG.md
ArthurFerrao Dec 16, 2024
4313028
feat: update popover description text
ArthurFerrao Dec 17, 2024
4b9b2ce
feat: add link to postal code finder website
ArthurFerrao Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion messages/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"store/shipping-option-zipcode.shippinFilter.pickpu": "Pickup",
"store/shipping-option-zipcode.updateButton.label": "Update",
"store/shipping-option-zipcode.popoverButton.label": "Select a location",
"store/shipping-option-zipcode.popover.description": "Delivery options and delivery speeds may vary per address and store.",
"store/shipping-option-zipcode.popover.description": "Offers and delivery options vary based on region.",
"store/shipping-option-zipcode.deliveryPopover.submitButton.label": "Continue",
"store/shipping-option-zipcode.deliveryPopover.postalCodeInput.placeholder": "Postal Code"
}
3 changes: 1 addition & 2 deletions messages/pt.json
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArthurFerrao I believe you missed updating the PT file. Also the store/shipping-option-zipcode.deliveryPopover.submitButton.label got removed, not sure if it was intetional...

Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,5 @@
"store/shipping-option-zipcode.shippinFilter.pickpu": "Retirada",
"store/shipping-option-zipcode.updateButton.label": "Atualizar",
"store/shipping-option-zipcode.popoverButton.label": "Selecione um local",
"store/shipping-option-zipcode.popover.description": "As opções e a velocidade de entrega podem variar conforme o endereço e a loja",
"store/shipping-option-zipcode.deliveryPopover.submitButton.label": "Continue"
"store/shipping-option-zipcode.popover.description": "As opções e a velocidade de entrega podem variar conforme o endereço e a loja"
}
Loading