-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add input in popover to define postal code #11
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
f80574e
to
1ba9470
Compare
|
messages/en.json
Outdated
"store/shipping-option-zipcode.popover.description": "Delivery options and delivery speeds may vary per address and store.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find a bit weird to use "speed" in this context. I would rather use estimates or other similar word. Because isn't rate like delivery per day...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. @ArthurFerrao Is this just a boiler plate before the localization team review? or it was suggested by the localization team?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the oldest text but I just changed it to what is in the new design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but I would revise the message along with the Designer
@salesfelipe I just changed this text to what is in the new design |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArthurFerrao I believe you missed updating the PT file. Also the store/shipping-option-zipcode.deliveryPopover.submitButton.label
got removed, not sure if it was intetional...
What problem is this solving?
This PR add a popover with input to encourage the user to enter a location.
How to test it?
Starts the page without postal code defined.
Workspace
Screenshots or example usage:
Gravacao.de.Tela.2024-12-16.as.13.57.40.mov
Describe alternatives you've considered, if any.
Related to / Depends on
How does this PR make you feel? 🔗
![](put .gif link here - can be found under "advanced" on giphy)