Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add input in popover to define postal code #11

Merged
merged 7 commits into from
Dec 17, 2024

Conversation

ArthurFerrao
Copy link
Contributor

What problem is this solving?

This PR add a popover with input to encourage the user to enter a location.

How to test it?

Starts the page without postal code defined.

Workspace

Screenshots or example usage:

Gravacao.de.Tela.2024-12-16.as.13.57.40.mov

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@ArthurFerrao ArthurFerrao added the enhancement New feature or request label Dec 16, 2024
@ArthurFerrao ArthurFerrao self-assigned this Dec 16, 2024
@ArthurFerrao ArthurFerrao requested a review from a team as a code owner December 16, 2024 16:59
Copy link

vtex-io-ci-cd bot commented Dec 16, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Dec 16, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

github-actions bot commented Dec 16, 2024

Fails
🚫

We follow keepachangelog standards.

Please, add a section to your changelog entry. Example:

 ## [Unreleased]

+ ### Fixed
 - Issue with image sizing in the SKU Selector.

You can use one of the following sections:

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Generated by 🚫 dangerJS against 4b9b2ce

messages/en.json Outdated
"store/shipping-option-zipcode.popover.description": "Delivery options and delivery speeds may vary per address and store.",
Copy link

@salesfelipe salesfelipe Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find a bit weird to use "speed" in this context. I would rather use estimates or other similar word. Because isn't rate like delivery per day...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. @ArthurFerrao Is this just a boiler plate before the localization team review? or it was suggested by the localization team?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the oldest text but I just changed it to what is in the new design

Copy link

@salesfelipe salesfelipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I would revise the message along with the Designer

@ArthurFerrao
Copy link
Contributor Author

Approved, but I would revise the message along with the Designer

@salesfelipe I just changed this text to what is in the new design

@ArthurFerrao ArthurFerrao merged commit 6f6569b into feat/delivery-popover Dec 17, 2024
4 of 5 checks passed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArthurFerrao I believe you missed updating the PT file. Also the store/shipping-option-zipcode.deliveryPopover.submitButton.label got removed, not sure if it was intetional...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants