Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout Button Schema #318

Merged
merged 3 commits into from
Dec 22, 2022

Conversation

filipewl
Copy link
Contributor

@filipewl filipewl commented Dec 22, 2022

Description copied from #315 because we couldn't get the PR checks working, so we had to open another PR. The checks are all working in this one, so we'll proceed with the merge here.


What problem are you trying to solve?.
Allow the checkout button redirect link to be edited via site editor.
Today, this behavior is controlled by the prop finishShoppingButtonLink(editable only via code).

It's interesting to go directly to the last checkout stage to speed up the checkout process.
However, when there is gift promotion, the only place where the user can choose the gift is on the first checkout stage:

Gifts-oficina

So it's useful for the commercial team to be able to change this behavior easily via site editor:
When there is a active gift promotion they would choose to send the user to the first checkout stage. Otherwise, they would choose the last checkout stage.

How to test it?

Workspace
Admin -> CMS/Site editor -> Cabeçalho(Desktop/mobile)
--> Minicart Footer --> Botão de checkout

Screenshots or example usage:

Screenshot from 2022-11-07 14-02-45

Related to #699

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Dec 22, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Dec 22, 2022

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@filipewl filipewl marked this pull request as ready for review December 22, 2022 18:19
@filipewl filipewl requested a review from a team as a code owner December 22, 2022 18:19
@filipewl filipewl changed the title Checkout Button Schema [2] Checkout Button Schema Dec 22, 2022
@filipewl filipewl mentioned this pull request Dec 22, 2022
@jpesce
Copy link

jpesce commented Dec 22, 2022

Coming from #315
Let me know if you need anything

Thanks!

@filipewl
Copy link
Contributor Author

filipewl commented Dec 22, 2022

As I have already approved the original PR #315, and cannot approve this one here because I opened it, I'm going to go ahead and bypass the "at least 1 approving review is required" to merge.

@filipewl filipewl merged commit a63f2a1 into master Dec 22, 2022
@filipewl filipewl deleted the feature/finish-checkout-button-via-admin-vtex-owner branch December 22, 2022 18:30
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Dec 22, 2022

Your PR has been merged! App is being published. 🚀
Version 2.63.5 → 2.64.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants