Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout Button Schema #315

Conversation

gealcan
Copy link

@gealcan gealcan commented Nov 7, 2022

What problem are you trying to solve?.
Allow the checkout button redirect link to be edited via site editor.
Today, this behavior is controlled by the prop finishShoppingButtonLink(editable only via code).

It's interesting to go directly to the last checkout stage to speed up the checkout process.
However, when there is gift promotion, the only place where the user can choose the gift is on the first checkout stage:

Gifts-oficina

So it's useful for the commercial team to be able to change this behavior easily via site editor:
When there is a active gift promotion they would choose to send the user to the first checkout stage. Otherwise, they would choose the last checkout stage.

How to test it?

Workspace
Admin -> CMS/Site editor -> Cabeçalho(Desktop/mobile)
--> Minicart Footer --> Botão de checkout

Screenshots or example usage:

Screenshot from 2022-11-07 14-02-45

Related to #699

@gealcan gealcan requested a review from a team as a code owner November 7, 2022 17:09
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 7, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@gealcan gealcan requested review from gvc, danzanzini and victorhmp and removed request for a team November 7, 2022 17:09
@filipewl
Copy link
Contributor

Hey @gealcan! We tried to access the workspace you created, but we're receiving the following error:
CleanShot 2022-12-19 at 18 20 36

Do you have any idea what's going on?

@filipewl
Copy link
Contributor

Hey! How did you manage to select the Checkout Button in the Site Editor? We tried here, but when we add some product to the cart and open the mini cart, we can't select the button with the Site Editor's selector.

@jpesce
Copy link

jpesce commented Dec 20, 2022

Hi @filipewl, thanks for reviewing!

Hey @gealcan! We tried to access the workspace you created, but we're receiving the following error
Do you have any idea what's going on?

Since this was implemented a long time ago, the workspace broke. I just created a new one with everything working. Here it is.

How did you manage to select the Checkout Button in the Site Editor?

Here's a screen recording on how to reach it:

checkout-button-schema.mp4

Copy link
Contributor

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and getting the workspace running again, and explaining how to edit it.
🙌

I was able to edit the path for the Checkout Button via the Site Editor and confirmed it reflected in the store.

`vtex-io/docs-outdated-select` and `vtexio/build` were stuck forever.

Not sure this will work though.
@filipewl filipewl mentioned this pull request Dec 22, 2022
@filipewl
Copy link
Contributor

filipewl commented Dec 22, 2022

Hey @gealcan and @jpesce! Due to some technical details, this PR seems stuck because we cannot get these 2 required checks running. I made a copy of this PR in #318, and over there, they're all passing, so we can proceed and merge that one. With that said, I'll close this one.

CleanShot 2022-12-22 at 15 23 21@2x

@filipewl filipewl closed this Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants