Invite to team fixes, improvements and API implementation #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpaulet
approved these changes
Nov 5, 2024
|
Set as draft since I'd like to implement the new invitations list here vocdoni/saas-backend#24 |
elboletaire
force-pushed
the
f/invite-to-team
branch
from
5650365
to
fc0a73c
Compare
elboletaire
force-pushed
the
f/invite-to-team
branch
from
eb9f4fd
to
7602211
Compare
- Moved team members table to a new component and edited that one to use the common component instead - Created a new PendingTeamMembersList component to show the pending members table/list - Created a new wrapper component to have both of them as <TeamMembers />
Also changed the order of the members table order to be more consistent
elboletaire
force-pushed
the
f/invite-to-team
branch
from
bff2da4
to
cdc44ac
Compare
- Created #839 to tackle an issue I've found doing this - Changed how the auth.ts routes were sorted in order to be able to reuse the AuthLayout without requiring an account to not be logged in. - Updated the signup component to be reused in the verification for non-existing accounts. - Minor changes to AuthProvider to have errors in an Enum - Most if not all cases covered, but the verification process needs a revamp: + If the invited user has an unverified account, a page with a button to go to the verify page is shown, but such verify requires the params in the URL, which cannot be get from this point (at all). The verify user needs a revamp so it can be accessed without url params, and show there a button to request a new code if required
|
@emmdim I've added the accept invite flow, see 2668963 Note though that, as I've said in the commit message, the "verify account" page needs a bit of a revamp (mainly allow adding fields manually, and a button to re-request the code if necessary). I haven't attacked this, since it was gonna increase (even more) my PR size. I've created an issue for it though, see #840 |
emmdim
reviewed
Nov 15, 2024
emmdim
reviewed
Nov 15, 2024
emmdim
reviewed
Nov 15, 2024
emmdim
reviewed
Nov 15, 2024
emmdim
reviewed
Nov 15, 2024
emmdim
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/components/Organization/Dashboardtosrc/components/OrganizationTeamscomponent, the specific dashboard page was created inelements.TeamMembersListto follow this patternTeamPendingMembersListcomponent to fetch and display the pending members list.While implementing the accept invitations flow...