Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify page should be interactive #840

Open
elboletaire opened this issue Nov 15, 2024 · 0 comments
Open

Verify page should be interactive #840

elboletaire opened this issue Nov 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@elboletaire
Copy link
Member

elboletaire commented Nov 15, 2024

Right now the verify page can only be accessed with the params defined in the URL. This page should show a form to allow manually adding the values in case they're not received in the URL.

Also, a "re-send code" button should be added for the required use cases.

This is required since some part of the invite flow relies on being able to access this URL without knowing the required URL params (see #828)

Edit: Actually, we currently have two different verification components:

  • One accessible via /account/verify, which is not interactive at all
  • Another one only loaded embedded in /account/signup, which shows a form to add the code.

I think we should unify them both, and use the embedded one as the default, since it already has the fields shown. The difference should be: if no params are provided, show the form. If params are provided, show the form too, but disabled and it should instantly show the button as loading because it's making the required calls.

Remember to also handle the "last verification code still valid" error in this revamp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant