The Hub UT framework should send what it received #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit the UT framework would send the registered operation. This was not useful for unit tests as it is those same tests that registered the operation, so they are aware of what it is. What is the tests need is for the framework to send the actual received GraphQL request so that it can be verified. This commit does this. Signed-off-by: Marc Khouzam <[email protected]>
marckhouzam
force-pushed
the
fix/graphqlTesting
branch
from
94b3cf4
to
2b714a1
Compare
marckhouzam
changed the title
anujc25
approved these changes
Oct 23, 2024
|
@marckhouzam Can you mention about the breaking change in this unit test framework as part of the ReleaseNotes as well? |
anujc25
pushed a commit
to anujc25/tanzu-plugin-runtime
that referenced
this pull request
Nov 5, 2024
Before this commit the UT framework would send the registered operation. This was not useful for unit tests as it is those same tests that registered the operation, so they are already aware of what it is. What the tests need is for the framework to send the actual received GraphQL request so that it can be verified. This commit does this. Signed-off-by: Marc Khouzam <[email protected]>
anujc25
pushed a commit
to anujc25/tanzu-plugin-runtime
that referenced
this pull request
Nov 5, 2024
Before this commit the UT framework would send the registered operation. This was not useful for unit tests as it is those same tests that registered the operation, so they are already aware of what it is. What the tests need is for the framework to send the actual received GraphQL request so that it can be verified. This commit does this. Signed-off-by: Marc Khouzam <[email protected]>
anujc25
added a commit
that referenced
this pull request
Nov 5, 2024
Before this commit the UT framework would send the registered operation. This was not useful for unit tests as it is those same tests that registered the operation, so they are already aware of what it is. What the tests need is for the framework to send the actual received GraphQL request so that it can be verified. This commit does this. Signed-off-by: Marc Khouzam <[email protected]> Co-authored-by: Marc Khouzam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Before this PR the UT framework would send the registered operation. This was not useful for unit tests as it is those same tests that registered the operation, so they are aware of what it is. What the tests need is for the framework to send the actual received GraphQL request so that it can be verified.
This PR does this.
NOTE: This change is not backwards-compatible. However, I feel it is early enough in the use of the UT framework and that the only ones using it are probably the CLI team, that we can easily adapt.
The unit tests of the UT framework are updated to check that the sent value is the actual query received by the mock server.
Which issue(s) this PR fixes
Follow-up to #202
Describe testing done for PR
I have an internal set of unit tests that now detects more failures by comparing the received graphql request with what the tests expect.
Release note
Additional information
Special notes for your reviewer