[Release-1.4] CherryPick: Have the Hub UT framework send what it received #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit the UT framework would send the registered operation. This was not useful for unit tests as it is those same tests that registered the operation, so they are already aware of what it is. What the tests need is for the framework to send the actual received GraphQL request so that it can be verified. This commit does this. Signed-off-by: Marc Khouzam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick: #206
What this PR does / why we need it
Before this commit the UT framework would send the registered operation. This was not useful for unit tests as it is those same tests that registered the operation, so they are already aware of what it is. What the tests need is for the framework to send the actual received GraphQL request so that it can be verified. This commit does this.
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer