Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce reference package for a Google Cloud SQL service instance #11

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Introduce reference package for a Google Cloud SQL service instance #11

merged 1 commit into from
Jul 19, 2022

Conversation

hoegaarden
Copy link
Contributor

Note: package repo bundle not updated yet, thus not "released"

Samze
Samze reviewed Jul 14, 2022
View reviewed changes
google/config-connector/cloudsql/README.md
Config Connector using Cloud SQL][stk]

<!-- TODO update when published -->
[stk]: https://docs.vmware.com/en/Services-Toolkit-for-VMware-Tanzu-Application-Platform/index.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought We may not be able to have this link until we resolve the question of how these more detailed docs become live. Let's not merge this until either:

  1. We have a better idea of how those docs become live - or maybe these should reside in this repo.
  2. We update this section to not link off to our docs and then we revisit this later to provide a link.

@hoegaarden hoegaarden force-pushed the horlh/gcp_postgres branch 5 times, most recently from da954a5 to 25535fd Compare July 15, 2022 13:56
@hoegaarden
Copy link
Contributor Author

In my local tests I stumbled upon an issue with the secretgen-controller. It seems if you use a password to create a secret, once it is created, this secret is not reconciled anymore. This is not blocking this PR or anything, but an interesting find.

@hoegaarden
Introduce reference package for a Google Cloud SQL service instance
020cbf7 
Note: package repo bundle not updated yet, thus not "released"
@hoegaarden hoegaarden force-pushed the horlh/gcp_postgres branch from 25535fd to 020cbf7 Compare July 18, 2022 12:53
@gmrodgers
Copy link
Contributor

Built this locally and deployed and created, a GCP CloudSQL instance 👍 :

kapp inspect -a first-ctrl -n service-instances
Target cluster 'https://35.199.34.76' (nodes: gke-docs-43-test-default-pool-5e75099b-26rn, 5+)

Resources in app 'first-ctrl'

Namespace          Name               Kind            Owner    Rs  Ri  Age  
service-instances  first              SQLDatabase     kapp     ok  -   7m  
^                  first              SQLInstance     kapp     ok  -   7m  
^                  first              SQLUser         kapp     ok  -   7m  
^                  first              SecretTemplate  kapp     ok  -   7m  
^                  first-admin-creds  Password        kapp     ok  -   7m  
^                  first-admin-creds  Secret          cluster  ok  -   7m  
^                  first-obj-reader   Role            kapp     ok  -   7m  
^                  first-obj-reader   RoleBinding     kapp     ok  -   7m  
^                  first-obj-reader   ServiceAccount  kapp     ok  -   7m  
^                  first-user-creds   Password        kapp     ok  -   7m  
^                  first-user-creds   Secret          cluster  ok  -   7m  

Rs: Reconcile state
Ri: Reconcile information

11 resources

Succeeded

@Samze
Copy link
Contributor

Samze commented Jul 19, 2022

Thanks for addressing the feedback! LGTM.

@Samze Samze merged commit be6416f into main Jul 19, 2022
@hoegaarden hoegaarden mentioned this pull request Jul 20, 2022
Merged
@hoegaarden hoegaarden mentioned this pull request Sep 13, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Feb 1, 2023
fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup!…
530d310 
… add explicit package write permissions

fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! add explicit package write permissions
fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! add explicit package write permissions
fixup! fixup! fixup! fixup! fixup! fixup! fixup! add explicit package write permissions
fixup! fixup! fixup! fixup! fixup! fixup! add explicit package write permissions
fixup! fixup! fixup! fixup! fixup! add explicit package write permissions
fixup! fixup! fixup! fixup! add explicit package write permissions
fixup! fixup! fixup! add explicit package write permissions
fixup! fixup! add explicit package write permissions
fixup! add explicit package write permissions
add explicit package write permissions
Merge branch 'develop'
Merge branch 'main' into develop
fix branch name for publish workflow
document multicloud psql crossplane package
create repo pr only for release branch
fixup! fix azure test script
fix azure test script
hide secret values from pipeline environment
warn about pre-release untested packages
build and release carvel packages and repository
fix missing variable definition
add labels to secret and use shared library
forgot to update helm and azure compositions to the upbound tf provider
fix crossplane aws provider name
implemented aws rds for public and private access
add aws rds composition
add safeguard against script failing
tf provider has been replaced with the official one
tweak the script to also support azure psql
minor tweaks to get it working
testing
small fixes
initial version of azure composition
add automation
move and fine tune package
fix publish workflow
change Makefile to use new packages location
refactor publish and test workloads
add crossplane multicloud psql package
fix crossplane paths for the publish workflow
add docs for azure mongodb with crossplane
fix theme colors to get closer to vmware's
fix crossplane aws provider documentation
add azure crossplane mongodb
add a new exaple golang app for Redis
feat(examples.postgresql) Add a new example golang app for PostgreSQL
aws elasticache docs and crossplane
Elasticache with Redis
fix README links, fix azure schema description
add READMEs
add capability to choose a name for the server different from the one used for kubernetes resources
add defaults and tags, add kapp waitrules for secretgen resources
add first version of azure psql package
Merge pull request #18 from vmware-tanzu/horlh/no-namespace-means-more-freedom
Fixes for renamed repository
Rename the sa/rbac files to better match what they are about
Make it easier to apply the "example" RBAC resources for RDS/ACK
Make it easier to apply the "example" RBAC resources
Publish a new version of the package repo
Merge pull request #11 from vmware-tanzu/horlh/gcp_postgres
Introduce reference package for a Google Cloud SQL service instance
Remove packageinstall from repository
Update README.md
Update CLA signing guidelines
Fix Code of conduct email address
Update Apache 2.0 LICENSE
Merge pull request #8 from vmware-tanzu/fix-typos-and-wording
Update packagerepo.yaml with comment fix.
Fix some types and changes some workings.
Change the packagerepo to namespace tanzu global.
Remove redundant sa file
Update name of RDS bundle
First implementation of Package for Amazon RDS
Adding NOTICE
Adding LICENSE
Adding .gitignore template
Add Code of Conduct template
Add CONTRIBUTING template
Add README template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samze Samze Samze left review comments

@teddyking teddyking Awaiting requested review from teddyking

@gmrodgers gmrodgers Awaiting requested review from gmrodgers

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoegaarden @gmrodgers @Samze @vmwclabot